From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K5hxU-0000Sq-Ub
	for qemu-devel@nongnu.org; Mon, 09 Jun 2008 10:02:52 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K5hxU-0000Rt-Ep
	for qemu-devel@nongnu.org; Mon, 09 Jun 2008 10:02:52 -0400
Received: from [199.232.76.173] (port=45883 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K5hxU-0000Rg-8e
	for qemu-devel@nongnu.org; Mon, 09 Jun 2008 10:02:52 -0400
Received: from savannah.gnu.org ([199.232.41.3]:39398 helo=sv.gnu.org)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@nowt.org>) id 1K5hxT-0006X8-U7
	for qemu-devel@nongnu.org; Mon, 09 Jun 2008 10:02:52 -0400
Received: from cvs.savannah.gnu.org ([199.232.41.69])
	by sv.gnu.org with esmtp (Exim 4.63) (envelope-from <paul@nowt.org>)
	id 1K5hxT-0005rj-BG
	for qemu-devel@nongnu.org; Mon, 09 Jun 2008 14:02:51 +0000
Received: from pbrook by cvs.savannah.gnu.org with local (Exim 4.63)
	(envelope-from <pbrook@savannah.gnu.org>) id 1K5hxT-0005rf-3S
	for qemu-devel@nongnu.org; Mon, 09 Jun 2008 14:02:51 +0000
MIME-Version: 1.0
Errors-To: pbrook
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Paul Brook <paul@nowt.org>
Message-Id: <E1K5hxT-0005rf-3S@cvs.savannah.gnu.org>
Date: Mon, 09 Jun 2008 14:02:51 +0000
Subject: [Qemu-devel] [4712] Use qemu_mallocz to allocate new thread state.
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Revision: 4712
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4712
Author:   pbrook
Date:     2008-06-09 14:02:50 +0000 (Mon, 09 Jun 2008)

Log Message:
-----------
Use qemu_mallocz to allocate new thread state.  Remove redundant memset.

Modified Paths:
--------------
    trunk/linux-user/main.c
    trunk/linux-user/syscall.c

Modified: trunk/linux-user/main.c
===================================================================
--- trunk/linux-user/main.c	2008-06-09 13:57:23 UTC (rev 4711)
+++ trunk/linux-user/main.c	2008-06-09 14:02:50 UTC (rev 4712)
@@ -2183,11 +2183,11 @@
 
 THREAD CPUState *thread_env;
 
+/* Assumes contents are already zeroed.  */
 void init_task_state(TaskState *ts)
 {
     int i;
  
-    memset(ts, 0, sizeof(TaskState));
     ts->used = 1;
     ts->first_free = ts->sigqueue_table;
     for (i = 0; i < MAX_SIGQUEUE_SIZE - 1; i++) {

Modified: trunk/linux-user/syscall.c
===================================================================
--- trunk/linux-user/syscall.c	2008-06-09 13:57:23 UTC (rev 4711)
+++ trunk/linux-user/syscall.c	2008-06-09 14:02:50 UTC (rev 4712)
@@ -2787,7 +2787,7 @@
         new_thread_info info;
         pthread_attr_t attr;
 #endif
-        ts = malloc(sizeof(TaskState) + NEW_STACK_SIZE);
+        ts = qemu_mallocz(sizeof(TaskState) + NEW_STACK_SIZE);
         init_task_state(ts);
         new_stack = ts->stack;
         /* we create a new CPU instance. */