From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K6Msr-0007BO-Ru
	for qemu-devel@nongnu.org; Wed, 11 Jun 2008 05:44:50 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K6Msp-00076x-34
	for qemu-devel@nongnu.org; Wed, 11 Jun 2008 05:44:48 -0400
Received: from [199.232.76.173] (port=47070 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K6Mso-00076g-Fg
	for qemu-devel@nongnu.org; Wed, 11 Jun 2008 05:44:46 -0400
Received: from savannah.gnu.org ([199.232.41.3]:38570 helo=sv.gnu.org)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <fabrice@bellard.org>) id 1K6Mso-000446-6C
	for qemu-devel@nongnu.org; Wed, 11 Jun 2008 05:44:46 -0400
Received: from cvs.savannah.gnu.org ([199.232.41.69])
	by sv.gnu.org with esmtp (Exim 4.63)
	(envelope-from <fabrice@bellard.org>) id 1K6Msn-0003AI-Is
	for qemu-devel@nongnu.org; Wed, 11 Jun 2008 09:44:45 +0000
Received: from bellard by cvs.savannah.gnu.org with local (Exim 4.63)
	(envelope-from <bellard@savannah.gnu.org>) id 1K6Msm-0003A9-W5
	for qemu-devel@nongnu.org; Wed, 11 Jun 2008 09:44:45 +0000
MIME-Version: 1.0
Errors-To: bellard
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Fabrice Bellard <fabrice@bellard.org>
Message-Id: <E1K6Msm-0003A9-W5@cvs.savannah.gnu.org>
Date: Wed, 11 Jun 2008 09:44:45 +0000
Subject: [Qemu-devel] [4727] using strncpy is *always* a bad idea
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Revision: 4727
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4727
Author:   bellard
Date:     2008-06-11 09:44:44 +0000 (Wed, 11 Jun 2008)

Log Message:
-----------
using strncpy is *always* a bad idea

Modified Paths:
--------------
    trunk/vl.c

Modified: trunk/vl.c
===================================================================
--- trunk/vl.c	2008-06-10 15:29:15 UTC (rev 4726)
+++ trunk/vl.c	2008-06-11 09:44:44 UTC (rev 4727)
@@ -3394,8 +3394,7 @@
 #ifndef _WIN32
 	if (is_unix) {
 	    char path[109];
-	    strncpy(path, uaddr.sun_path, 108);
-	    path[108] = 0;
+	    pstrcpy(path, sizeof(path), uaddr.sun_path);
 	    unlink(path);
 	} else
 #endif
@@ -5075,7 +5074,7 @@
     }
 
     if (get_param_value(buf, sizeof(buf), "if", str)) {
-        strncpy(devname, buf, sizeof(devname));
+        pstrcpy(devname, sizeof(devname), buf);
         if (!strcmp(buf, "ide")) {
 	    type = IF_IDE;
             max_devs = MAX_IDE_DEVS;