From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [4755] cmpxchg fixes
Date: Fri, 20 Jun 2008 14:18:36 +0000 [thread overview]
Message-ID: <E1K9hRk-0003Ty-GH@cvs.savannah.gnu.org> (raw)
Revision: 4755
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4755
Author: bellard
Date: 2008-06-20 14:18:35 +0000 (Fri, 20 Jun 2008)
Log Message:
-----------
cmpxchg fixes
Modified Paths:
--------------
trunk/target-i386/op_helper.c
Modified: trunk/target-i386/op_helper.c
===================================================================
--- trunk/target-i386/op_helper.c 2008-06-19 18:38:40 UTC (rev 4754)
+++ trunk/target-i386/op_helper.c 2008-06-20 14:18:35 UTC (rev 4755)
@@ -1837,6 +1837,8 @@
stq(a0, ((uint64_t)ECX << 32) | (uint32_t)EBX);
eflags |= CC_Z;
} else {
+ /* always do the store */
+ stq(a0, d);
EDX = (uint32_t)(d >> 32);
EAX = (uint32_t)d;
eflags &= ~CC_Z;
@@ -1850,6 +1852,8 @@
uint64_t d0, d1;
int eflags;
+ if ((a0 & 0xf) != 0)
+ raise_exception(EXCP0D_GPF);
eflags = cc_table[CC_OP].compute_all();
d0 = ldq(a0);
d1 = ldq(a0 + 8);
@@ -1858,6 +1862,9 @@
stq(a0 + 8, ECX);
eflags |= CC_Z;
} else {
+ /* always do the store */
+ stq(a0, d0);
+ stq(a0 + 8, d1);
EDX = d1;
EAX = d0;
eflags &= ~CC_Z;
reply other threads:[~2008-06-20 14:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1K9hRk-0003Ty-GH@cvs.savannah.gnu.org \
--to=fabrice@bellard.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).