From: Blue Swirl <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [4782] Fix some compiler signed/unsigned char warnings
Date: Mon, 23 Jun 2008 17:52:44 +0000 [thread overview]
Message-ID: <E1KAqDc-0000kt-Bn@cvs.savannah.gnu.org> (raw)
Revision: 4782
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4782
Author: blueswir1
Date: 2008-06-23 17:52:43 +0000 (Mon, 23 Jun 2008)
Log Message:
-----------
Fix some compiler signed/unsigned char warnings
Modified Paths:
--------------
trunk/hw/firmware_abi.h
trunk/hw/sun4m.c
trunk/hw/sun4u.c
Modified: trunk/hw/firmware_abi.h
===================================================================
--- trunk/hw/firmware_abi.h 2008-06-23 16:58:04 UTC (rev 4781)
+++ trunk/hw/firmware_abi.h 2008-06-23 17:52:43 UTC (rev 4782)
@@ -139,7 +139,7 @@
}
static inline uint32_t
-OpenBIOS_set_var(uint8_t *nvram, uint32_t addr, const unsigned char *str)
+OpenBIOS_set_var(uint8_t *nvram, uint32_t addr, const char *str)
{
uint32_t len;
Modified: trunk/hw/sun4m.c
===================================================================
--- trunk/hw/sun4m.c 2008-06-23 16:58:04 UTC (rev 4781)
+++ trunk/hw/sun4m.c 2008-06-23 17:52:43 UTC (rev 4782)
@@ -159,7 +159,7 @@
for (i = 0; i < sizeof(image); i++)
image[i] = m48t59_read(nvram, i) & 0xff;
- strcpy(header->boot_devices, boot_device);
+ strcpy((char *)header->boot_devices, boot_device);
header->nboot_devices = strlen(boot_device) & 0xff;
header->crc = cpu_to_be16(OHW_compute_crc(header, 0x00, 0xF8));
@@ -187,17 +187,17 @@
memset(image, '\0', sizeof(image));
// Try to match PPC NVRAM
- strcpy(header->struct_ident, "QEMU_BIOS");
+ strcpy((char *)header->struct_ident, "QEMU_BIOS");
header->struct_version = cpu_to_be32(3); /* structure v3 */
header->nvram_size = cpu_to_be16(0x2000);
header->nvram_arch_ptr = cpu_to_be16(sizeof(ohwcfg_v3_t));
header->nvram_arch_size = cpu_to_be16(sizeof(struct sparc_arch_cfg));
- strcpy(header->arch, arch);
+ strcpy((char *)header->arch, arch);
header->nb_cpus = smp_cpus & 0xff;
header->RAM0_base = 0;
header->RAM0_size = cpu_to_be64((uint64_t)RAM_size);
- strcpy(header->boot_devices, boot_devices);
+ strcpy((char *)header->boot_devices, boot_devices);
header->nboot_devices = strlen(boot_devices) & 0xff;
header->kernel_image = cpu_to_be64((uint64_t)KERNEL_LOAD_ADDR);
header->kernel_size = cpu_to_be64((uint64_t)kernel_size);
Modified: trunk/hw/sun4u.c
===================================================================
--- trunk/hw/sun4u.c 2008-06-23 16:58:04 UTC (rev 4781)
+++ trunk/hw/sun4u.c 2008-06-23 17:52:43 UTC (rev 4782)
@@ -78,7 +78,7 @@
for (i = 0; i < sizeof(image); i++)
image[i] = m48t59_read(nvram, i) & 0xff;
- strcpy(header->boot_devices, boot_device);
+ strcpy((char *)header->boot_devices, boot_device);
header->nboot_devices = strlen(boot_device) & 0xff;
header->crc = cpu_to_be16(OHW_compute_crc(header, 0x00, 0xF8));
@@ -91,7 +91,7 @@
extern int nographic;
static int sun4u_NVRAM_set_params (m48t59_t *nvram, uint16_t NVRAM_size,
- const unsigned char *arch,
+ const char *arch,
ram_addr_t RAM_size,
const char *boot_devices,
uint32_t kernel_image, uint32_t kernel_size,
@@ -110,17 +110,17 @@
memset(image, '\0', sizeof(image));
// Try to match PPC NVRAM
- strcpy(header->struct_ident, "QEMU_BIOS");
+ strcpy((char *)header->struct_ident, "QEMU_BIOS");
header->struct_version = cpu_to_be32(3); /* structure v3 */
header->nvram_size = cpu_to_be16(NVRAM_size);
header->nvram_arch_ptr = cpu_to_be16(sizeof(ohwcfg_v3_t));
header->nvram_arch_size = cpu_to_be16(sizeof(struct sparc_arch_cfg));
- strcpy(header->arch, arch);
+ strcpy((char *)header->arch, arch);
header->nb_cpus = smp_cpus & 0xff;
header->RAM0_base = 0;
header->RAM0_size = cpu_to_be64((uint64_t)RAM_size);
- strcpy(header->boot_devices, boot_devices);
+ strcpy((char *)header->boot_devices, boot_devices);
header->nboot_devices = strlen(boot_devices) & 0xff;
header->kernel_image = cpu_to_be64((uint64_t)kernel_image);
header->kernel_size = cpu_to_be64((uint64_t)kernel_size);
reply other threads:[~2008-06-23 17:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1KAqDc-0000kt-Bn@cvs.savannah.gnu.org \
--to=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).