* [Qemu-devel] [4987] only check RCTL_EN in e1000_can_receive()
@ 2008-08-06 14:11 Anthony Liguori
0 siblings, 0 replies; only message in thread
From: Anthony Liguori @ 2008-08-06 14:11 UTC (permalink / raw)
To: qemu-devel
Revision: 4987
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4987
Author: aliguori
Date: 2008-08-06 14:11:44 +0000 (Wed, 06 Aug 2008)
Log Message:
-----------
only check RCTL_EN in e1000_can_receive()
e1000_receive() has code to raise a receive overflow interrupt when the receive
buffer head and tail match. However, with the present implementation of
e1000_can_receive(), this code is unreachable -- and etherboot breaks as a
result.
Signed-off-by: Charles Duffy <charles_duffy@messageone.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Modified Paths:
--------------
trunk/hw/e1000.c
Modified: trunk/hw/e1000.c
===================================================================
--- trunk/hw/e1000.c 2008-08-06 08:37:17 UTC (rev 4986)
+++ trunk/hw/e1000.c 2008-08-06 14:11:44 UTC (rev 4987)
@@ -524,8 +524,7 @@
{
E1000State *s = opaque;
- return (!(s->mac_reg[RCTL] & E1000_RCTL_EN) ||
- s->mac_reg[RDH] != s->mac_reg[RDT]);
+ return (s->mac_reg[RCTL] & E1000_RCTL_EN);
}
static void
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-08-06 14:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-06 14:11 [Qemu-devel] [4987] only check RCTL_EN in e1000_can_receive() Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).