From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KStpu-0007v3-Hl
	for qemu-devel@nongnu.org; Tue, 12 Aug 2008 09:22:54 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KStps-0007rL-Kh
	for qemu-devel@nongnu.org; Tue, 12 Aug 2008 09:22:54 -0400
Received: from [199.232.76.173] (port=36060 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KStps-0007qz-Cj
	for qemu-devel@nongnu.org; Tue, 12 Aug 2008 09:22:52 -0400
Received: from savannah.gnu.org ([199.232.41.3]:51391 helo=sv.gnu.org)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <anthony@codemonkey.ws>)
	id 1KStps-0002iw-I3
	for qemu-devel@nongnu.org; Tue, 12 Aug 2008 09:22:52 -0400
Received: from cvs.savannah.gnu.org ([199.232.41.69])
	by sv.gnu.org with esmtp (Exim 4.63)
	(envelope-from <anthony@codemonkey.ws>) id 1KStpr-00055y-4z
	for qemu-devel@nongnu.org; Tue, 12 Aug 2008 13:22:51 +0000
Received: from aliguori by cvs.savannah.gnu.org with local (Exim 4.63)
	(envelope-from <aliguori@savannah.gnu.org>) id 1KStpq-00055o-Qs
	for qemu-devel@nongnu.org; Tue, 12 Aug 2008 13:22:51 +0000
MIME-Version: 1.0
Errors-To: aliguori
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Anthony Liguori <anthony@codemonkey.ws>
Message-Id: <E1KStpq-00055o-Qs@cvs.savannah.gnu.org>
Date: Tue, 12 Aug 2008 13:22:50 +0000
Subject: [Qemu-devel] [4995] serial: Always update iir,
	even when ier is empty (Samuel Thibault)
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Revision: 4995
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4995
Author:   aliguori
Date:     2008-08-12 13:22:50 +0000 (Tue, 12 Aug 2008)

Log Message:
-----------
serial: Always update iir, even when ier is empty (Samuel Thibault)

This fixes installation of Windows XP.

Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Modified Paths:
--------------
    trunk/hw/serial.c

Modified: trunk/hw/serial.c
===================================================================
--- trunk/hw/serial.c	2008-08-11 18:52:14 UTC (rev 4994)
+++ trunk/hw/serial.c	2008-08-12 13:22:50 UTC (rev 4995)
@@ -189,11 +189,6 @@
 {
     uint8_t tmp_iir = UART_IIR_NO_INT;
 
-    if (!s->ier) {
-        qemu_irq_lower(s->irq);
-        return;
-    }
-
     if ((s->ier & UART_IER_RLSI) && (s->lsr & UART_LSR_INT_ANY)) {
         tmp_iir = UART_IIR_RLSI;
     } else if (s->timeout_ipending) {