qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [5007] qcow2: Make sure to return an error when L2 table loading fails
Date: Thu, 14 Aug 2008 18:11:00 +0000	[thread overview]
Message-ID: <E1KThHo-00025R-GE@cvs.savannah.gnu.org> (raw)

Revision: 5007
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5007
Author:   aliguori
Date:     2008-08-14 18:11:00 +0000 (Thu, 14 Aug 2008)

Log Message:
-----------
qcow2: Make sure to return an error when L2 table loading fails

This was suggested by Kevin Wolf since this is, in fact, an error condition.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Modified Paths:
--------------
    trunk/block-qcow2.c

Modified: trunk/block-qcow2.c
===================================================================
--- trunk/block-qcow2.c	2008-08-14 18:10:28 UTC (rev 5006)
+++ trunk/block-qcow2.c	2008-08-14 18:11:00 UTC (rev 5007)
@@ -669,7 +669,7 @@
     l2_offset &= ~QCOW_OFLAG_COPIED;
     l2_table = l2_load(bs, l2_offset);
     if (l2_table == NULL)
-        goto out;
+        return 0;
 
     /* find the cluster offset for the given disk offset */
 

                 reply	other threads:[~2008-08-14 18:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1KThHo-00025R-GE@cvs.savannah.gnu.org \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).