From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KV5HT-0007FM-JU
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:00:23 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KV5HT-0007F8-8r
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:00:23 -0400
Received: from [199.232.76.173] (port=34034 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KV5HS-0007F5-VE
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:00:22 -0400
Received: from savannah.gnu.org ([199.232.41.3]:54983 helo=sv.gnu.org)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <anthony@codemonkey.ws>)
	id 1KV5HS-0006fy-Cv
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:00:22 -0400
Received: from cvs.savannah.gnu.org ([199.232.41.69])
	by sv.gnu.org with esmtp (Exim 4.63)
	(envelope-from <anthony@codemonkey.ws>) id 1KV5HR-0006QX-EW
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 14:00:21 +0000
Received: from aliguori by cvs.savannah.gnu.org with local (Exim 4.63)
	(envelope-from <aliguori@savannah.gnu.org>) id 1KV5HQ-0006Py-TW
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 14:00:21 +0000
MIME-Version: 1.0
Errors-To: aliguori
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Anthony Liguori <anthony@codemonkey.ws>
Message-Id: <E1KV5HQ-0006Py-TW@cvs.savannah.gnu.org>
Date: Mon, 18 Aug 2008 14:00:20 +0000
Subject: [Qemu-devel] [5023] Report unmapped addresses in memory_dump (Jan
	Kiszka)
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Revision: 5023
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5023
Author:   aliguori
Date:     2008-08-18 14:00:20 +0000 (Mon, 18 Aug 2008)

Log Message:
-----------
Report unmapped addresses in memory_dump (Jan Kiszka)

Instead of dumping incorrect (ie. previously read) data, report the
invalid virtual address to the user.

Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Modified Paths:
--------------
    trunk/monitor.c

Modified: trunk/monitor.c
===================================================================
--- trunk/monitor.c	2008-08-17 20:26:25 UTC (rev 5022)
+++ trunk/monitor.c	2008-08-18 14:00:20 UTC (rev 5023)
@@ -596,7 +596,10 @@
             env = mon_get_cpu();
             if (!env)
                 break;
-            cpu_memory_rw_debug(env, addr, buf, l, 0);
+            if (cpu_memory_rw_debug(env, addr, buf, l, 0) < 0) {
+                term_printf(" Cannot access memory\n");
+                break;
+            }
         }
         i = 0;
         while (i < l) {