From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KWFtY-0005UL-3t
	for qemu-devel@nongnu.org; Thu, 21 Aug 2008 15:32:32 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KWFtX-0005To-Dh
	for qemu-devel@nongnu.org; Thu, 21 Aug 2008 15:32:31 -0400
Received: from [199.232.76.173] (port=41512 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KWFtX-0005Tg-61
	for qemu-devel@nongnu.org; Thu, 21 Aug 2008 15:32:31 -0400
Received: from savannah.gnu.org ([199.232.41.3]:57256 helo=sv.gnu.org)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <anthony@codemonkey.ws>)
	id 1KWFtX-0006hh-B8
	for qemu-devel@nongnu.org; Thu, 21 Aug 2008 15:32:31 -0400
Received: from cvs.savannah.gnu.org ([199.232.41.69])
	by sv.gnu.org with esmtp (Exim 4.63)
	(envelope-from <anthony@codemonkey.ws>) id 1KWFtW-0005RP-5D
	for qemu-devel@nongnu.org; Thu, 21 Aug 2008 19:32:30 +0000
Received: from aliguori by cvs.savannah.gnu.org with local (Exim 4.63)
	(envelope-from <aliguori@savannah.gnu.org>) id 1KWFtV-0005RL-Tx
	for qemu-devel@nongnu.org; Thu, 21 Aug 2008 19:32:30 +0000
MIME-Version: 1.0
Errors-To: aliguori
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Anthony Liguori <anthony@codemonkey.ws>
Message-Id: <E1KWFtV-0005RL-Tx@cvs.savannah.gnu.org>
Date: Thu, 21 Aug 2008 19:32:29 +0000
Subject: [Qemu-devel] [5053] husb: Fixup printfs and stuff based on the
 review comments ( Max Krasnyansky)
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Revision: 5053
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5053
Author:   aliguori
Date:     2008-08-21 19:32:29 +0000 (Thu, 21 Aug 2008)

Log Message:
-----------
husb: Fixup printfs and stuff based on the review comments (Max Krasnyansky)

Addressing Anthony's comments regarding printf and stuff.

Anthony, if you you want I can fold this commit and resend
the original patch.

Signed-off-by: Max Krasnyansky <maxk@kernel.org>
Signed-off-by: AnthonY Liguori <aliguori@us.ibm.com>

Modified Paths:
--------------
    trunk/usb-linux.c

Modified: trunk/usb-linux.c
===================================================================
--- trunk/usb-linux.c	2008-08-21 19:31:52 UTC (rev 5052)
+++ trunk/usb-linux.c	2008-08-21 19:32:29 UTC (rev 5053)
@@ -272,7 +272,7 @@
     }
 
     if (i >= dev->descr_len) {
-        printf("husb: update iface failed. no matching configuration\n");
+        fprintf(stderr, "husb: update iface failed. no matching configuration\n");
         goto fail;
     }
     nb_interfaces = dev->descr[i + 4];
@@ -815,9 +815,6 @@
         return 0;
 
     for (f = usb_auto_filter; f; f = f->next) {
-        // printf("Auto match: bus_num %d addr %d vid %d pid %d\n",
-	//    bus_num, addr, vendor_id, product_id);
-
 	if (f->bus_num >= 0 && f->bus_num != bus_num)
             continue;
 
@@ -860,8 +857,8 @@
 {
     struct USBAutoFilter *f = qemu_mallocz(sizeof(*f));
     if (!f) {
-        printf("husb: failed to allocate auto filter\n");
-	return;
+        fprintf(stderr, "husb: failed to allocate auto filter\n");
+        return;
     }
 
     f->bus_num = bus_num;
@@ -878,7 +875,7 @@
          */
 	usb_auto_timer = qemu_new_timer(rt_clock, usb_host_auto_timer, NULL);
 	if (!usb_auto_timer) {
-            printf("husb: failed to allocate timer\n");
+            fprintf(stderr, "husb: failed to allocate auto scan timer\n");
             qemu_free(f);
             return;
         }