* [Qemu-devel] [5132] SH4: fix a regression introduced in r5122
@ 2008-09-02 8:42 Aurelien Jarno
2008-09-02 23:01 ` Sebastian Kaliszewski
0 siblings, 1 reply; 3+ messages in thread
From: Aurelien Jarno @ 2008-09-02 8:42 UTC (permalink / raw)
To: qemu-devel
Revision: 5132
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5132
Author: aurel32
Date: 2008-09-02 08:42:16 +0000 (Tue, 02 Sep 2008)
Log Message:
-----------
SH4: fix a regression introduced in r5122
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Modified Paths:
--------------
trunk/target-sh4/translate.c
Modified: trunk/target-sh4/translate.c
===================================================================
--- trunk/target-sh4/translate.c 2008-09-02 00:09:35 UTC (rev 5131)
+++ trunk/target-sh4/translate.c 2008-09-02 08:42:16 UTC (rev 5132)
@@ -1392,7 +1392,7 @@
tcg_gen_qemu_st32 (cpu_##reg, addr, ctx->memidx); \
tcg_temp_free(addr); \
tcg_gen_subi_i32(REG(B11_8), REG(B11_8), 4); \
- }
+ } \
return;
LDST(gbr, 0x401e, 0x4017, 0x0012, 0x4013)
LDST(vbr, 0x402e, 0x4027, 0x0022, 0x4023)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [5132] SH4: fix a regression introduced in r5122
2008-09-02 8:42 [Qemu-devel] [5132] SH4: fix a regression introduced in r5122 Aurelien Jarno
@ 2008-09-02 23:01 ` Sebastian Kaliszewski
2008-09-03 4:23 ` Paul Mundt
0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Kaliszewski @ 2008-09-02 23:01 UTC (permalink / raw)
To: qemu-devel
Dnia Tuesday 02 of September 2008, Aurelien Jarno napisał:
> Revision: 5132
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5132
> Author: aurel32
> Date: 2008-09-02 08:42:16 +0000 (Tue, 02 Sep 2008)
>
> Log Message:
> -----------
> SH4: fix a regression introduced in r5122
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>
> Modified Paths:
> --------------
> trunk/target-sh4/translate.c
>
> Modified: trunk/target-sh4/translate.c
> ===================================================================
> --- trunk/target-sh4/translate.c 2008-09-02 00:09:35 UTC (rev 5131)
> +++ trunk/target-sh4/translate.c 2008-09-02 08:42:16 UTC (rev 5132)
> @@ -1392,7 +1392,7 @@
> tcg_gen_qemu_st32 (cpu_##reg, addr, ctx->memidx); \
> tcg_temp_free(addr); \
> tcg_gen_subi_i32(REG(B11_8), REG(B11_8), 4); \
> - }
> + } \
> return;
> LDST(gbr, 0x401e, 0x4017, 0x0012, 0x4013)
> LDST(vbr, 0x402e, 0x4027, 0x0022, 0x4023)
Hello!
Hmm, this is just adding one space, are you sure the right thing go commited
rgds
\S.K.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [5132] SH4: fix a regression introduced in r5122
2008-09-02 23:01 ` Sebastian Kaliszewski
@ 2008-09-03 4:23 ` Paul Mundt
0 siblings, 0 replies; 3+ messages in thread
From: Paul Mundt @ 2008-09-03 4:23 UTC (permalink / raw)
To: qemu-devel
On Wed, Sep 03, 2008 at 01:01:17AM +0200, Sebastian Kaliszewski wrote:
> Dnia Tuesday 02 of September 2008, Aurelien Jarno napisa??:
> > Revision: 5132
> > http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5132
> > Author: aurel32
> > Date: 2008-09-02 08:42:16 +0000 (Tue, 02 Sep 2008)
> >
> > Log Message:
> > -----------
> > SH4: fix a regression introduced in r5122
> >
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> >
> > Modified Paths:
> > --------------
> > trunk/target-sh4/translate.c
> >
> > Modified: trunk/target-sh4/translate.c
> > ===================================================================
> > --- trunk/target-sh4/translate.c 2008-09-02 00:09:35 UTC (rev 5131)
> > +++ trunk/target-sh4/translate.c 2008-09-02 08:42:16 UTC (rev 5132)
> > @@ -1392,7 +1392,7 @@
> > tcg_gen_qemu_st32 (cpu_##reg, addr, ctx->memidx); \
> > tcg_temp_free(addr); \
> > tcg_gen_subi_i32(REG(B11_8), REG(B11_8), 4); \
> > - }
> > + } \
> > return;
> > LDST(gbr, 0x401e, 0x4017, 0x0012, 0x4013)
> > LDST(vbr, 0x402e, 0x4027, 0x0022, 0x4023)
>
> Hello!
>
> Hmm, this is just adding one space, are you sure the right thing go commited
>
Read again. It's adding a \ so the return; is factored in to the macro.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-09-03 4:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-02 8:42 [Qemu-devel] [5132] SH4: fix a regression introduced in r5122 Aurelien Jarno
2008-09-02 23:01 ` Sebastian Kaliszewski
2008-09-03 4:23 ` Paul Mundt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).