qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [5141] SH4: R2D-PLUS FPGA: simply unassigned memory triggering
Date: Tue, 02 Sep 2008 23:26:24 +0000	[thread overview]
Message-ID: <E1KafGS-0000N0-K1@cvs.savannah.gnu.org> (raw)

Revision: 5141
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5141
Author:   aurel32
Date:     2008-09-02 23:26:23 +0000 (Tue, 02 Sep 2008)

Log Message:
-----------
SH4: R2D-PLUS FPGA: simply unassigned memory triggering

Use NULL to trigger unassigned memory error on 32-bit accesses instead
of assert(0) as suggested by Blue Swirl.

Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

Modified Paths:
--------------
    trunk/hw/r2d.c

Modified: trunk/hw/r2d.c
===================================================================
--- trunk/hw/r2d.c	2008-09-02 23:26:13 UTC (rev 5140)
+++ trunk/hw/r2d.c	2008-09-02 23:26:23 UTC (rev 5141)
@@ -27,7 +27,6 @@
 #include "sh.h"
 #include "sysemu.h"
 #include "boards.h"
-#include "assert.h"
 
 #define SDRAM_BASE 0x0c000000 /* Physical location of SDRAM: Area 3 */
 #define SDRAM_SIZE 0x04000000
@@ -100,29 +99,16 @@
     }
 }
 
-static uint32_t invalid_read(void *opaque, target_phys_addr_t addr)
-{
-    assert(0);
-
-    return 0;
-}
-
-static void invalid_write(void *opaque, target_phys_addr_t addr,
-			  uint32_t mem_value)
-{
-    assert(0);
-}
-
 static CPUReadMemoryFunc *r2d_fpga_readfn[] = {
     r2d_fpga_read,
     r2d_fpga_read,
-    invalid_read,
+    NULL,
 };
 
 static CPUWriteMemoryFunc *r2d_fpga_writefn[] = {
     r2d_fpga_write,
     r2d_fpga_write,
-    invalid_write,
+    NULL,
 };
 
 static void r2d_fpga_init(target_phys_addr_t base)

                 reply	other threads:[~2008-09-02 23:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1KafGS-0000N0-K1@cvs.savannah.gnu.org \
    --to=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).