From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kds3G-0001pK-RD
	for qemu-devel@nongnu.org; Thu, 11 Sep 2008 15:42:02 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kds3F-0001np-M9
	for qemu-devel@nongnu.org; Thu, 11 Sep 2008 15:42:02 -0400
Received: from [199.232.76.173] (port=56152 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kds3F-0001nd-Dm
	for qemu-devel@nongnu.org; Thu, 11 Sep 2008 15:42:01 -0400
Received: from savannah.gnu.org ([199.232.41.3]:49730 helo=sv.gnu.org)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <INVALID.NOREPLY@gnu.org>)
	id 1Kds3F-0001ZG-6g
	for qemu-devel@nongnu.org; Thu, 11 Sep 2008 15:42:01 -0400
Received: from cvs.savannah.gnu.org ([199.232.41.69])
	by sv.gnu.org with esmtp (Exim 4.63)
	(envelope-from <INVALID.NOREPLY@gnu.org>) id 1Kds3E-0001mT-HF
	for qemu-devel@nongnu.org; Thu, 11 Sep 2008 19:42:00 +0000
Received: from aliguori by cvs.savannah.gnu.org with local (Exim 4.63)
	(envelope-from <aliguori@savannah.gnu.org>) id 1Kds3E-0001mP-Bs
	for qemu-devel@nongnu.org; Thu, 11 Sep 2008 19:42:00 +0000
MIME-Version: 1.0
Errors-To: aliguori
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Anthony Liguori <anthony@codemonkey.ws>
Message-Id: <E1Kds3E-0001mP-Bs@cvs.savannah.gnu.org>
Date: Thu, 11 Sep 2008 19:42:00 +0000
Subject: [Qemu-devel] [5199] uhci: Change default transaction lifetime to 32
 frames ( Max Krasnyansky)
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Revision: 5199
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5199
Author:   aliguori
Date:     2008-09-11 19:42:00 +0000 (Thu, 11 Sep 2008)

Log Message:
-----------
uhci: Change default transaction lifetime to 32 frames (Max Krasnyansky)

Transaction lifetime was originally set to 10 frames. That was an arbitrary
number I picked without much thinking :).
I'm changing that to 32 frames because things like interrupt transfers
and such are scheduled at that rate. It seems like 1/32 is accepted as
lowest supported rate. OHCI, for example, defines exactly 32 interrupt
heads.

While testing USB webcam under XP I noticed that interrupt transactions were
being canceled and then resubmitted on a regular basis, which works but is a
waste of CPU cycles. This change fixes that.
All other devices I have are not affected.

Signed-off-by: Max Krasnyansky <maxk@kernel.org>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Modified Paths:
--------------
    trunk/hw/usb-uhci.c

Modified: trunk/hw/usb-uhci.c
===================================================================
--- trunk/hw/usb-uhci.c	2008-09-11 18:16:02 UTC (rev 5198)
+++ trunk/hw/usb-uhci.c	2008-09-11 19:42:00 UTC (rev 5199)
@@ -781,7 +781,7 @@
     async = uhci_async_find_td(s, addr, td->token);
     if (async) {
         /* Already submitted */
-        async->valid = 10;
+        async->valid = 32;
 
         if (!async->done)
             return 1;