* [Qemu-devel] [5233] block-raw is not a protocol
@ 2008-09-16 13:21 Anthony Liguori
0 siblings, 0 replies; only message in thread
From: Anthony Liguori @ 2008-09-16 13:21 UTC (permalink / raw)
To: qemu-devel
Revision: 5233
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5233
Author: aliguori
Date: 2008-09-16 13:21:58 +0000 (Tue, 16 Sep 2008)
Log Message:
-----------
block-raw is not a protocol
The protocol_name "file" was added to the block driver when async IO was
introduced. This can be used to select that a file is treated as a raw
device instead of probing for the type. However, protocols are not subject
to path interpretation which cases qcow2 images with raw base images to not
function is the path was specified relatively.
The fix is simply to remove the protocol_name from the raw block driver. The
proper way to force the use of a raw block format is to use the format= option
with -drive.
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Modified Paths:
--------------
trunk/block-raw-posix.c
trunk/block-raw-win32.c
Modified: trunk/block-raw-posix.c
===================================================================
--- trunk/block-raw-posix.c 2008-09-15 22:26:35 UTC (rev 5232)
+++ trunk/block-raw-posix.c 2008-09-16 13:21:58 UTC (rev 5233)
@@ -846,7 +846,6 @@
.bdrv_aio_cancel = raw_aio_cancel,
.aiocb_size = sizeof(RawAIOCB),
#endif
- .protocol_name = "file",
.bdrv_pread = raw_pread,
.bdrv_pwrite = raw_pwrite,
.bdrv_truncate = raw_truncate,
Modified: trunk/block-raw-win32.c
===================================================================
--- trunk/block-raw-win32.c 2008-09-15 22:26:35 UTC (rev 5232)
+++ trunk/block-raw-win32.c 2008-09-16 13:21:58 UTC (rev 5233)
@@ -369,7 +369,6 @@
.bdrv_aio_cancel = raw_aio_cancel,
.aiocb_size = sizeof(RawAIOCB);
#endif
- .protocol_name = "file",
.bdrv_pread = raw_pread,
.bdrv_pwrite = raw_pwrite,
.bdrv_truncate = raw_truncate,
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-09-16 13:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-16 13:21 [Qemu-devel] [5233] block-raw is not a protocol Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).