From: Andrzej Zaborowski <balrogg@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [5239] 16550A UART: RHR irq enable bit also masks the Rx timeout irq.
Date: Wed, 17 Sep 2008 00:21:06 +0000 [thread overview]
Message-ID: <E1Kfkn4-0001R1-TT@cvs.savannah.gnu.org> (raw)
Revision: 5239
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5239
Author: balrog
Date: 2008-09-17 00:21:05 +0000 (Wed, 17 Sep 2008)
Log Message:
-----------
16550A UART: RHR irq enable bit also masks the Rx timeout irq.
The "Rx timeout" (aka. Character Timeout Indication) has no separate mask
bit in the IER register and according to the specs reading RHR is the only
way to reset the irq. However on the hardware (tested on OMAP2 UART which
is an extended 16550A) the RHR_IT bit in IER disables the irc, too. Linux
bluetooth serial dongle driver for N800 depends on this behavior.
Modified Paths:
--------------
trunk/hw/serial.c
Modified: trunk/hw/serial.c
===================================================================
--- trunk/hw/serial.c 2008-09-16 22:44:25 UTC (rev 5238)
+++ trunk/hw/serial.c 2008-09-17 00:21:05 UTC (rev 5239)
@@ -191,7 +191,7 @@
if ((s->ier & UART_IER_RLSI) && (s->lsr & UART_LSR_INT_ANY)) {
tmp_iir = UART_IIR_RLSI;
- } else if (s->timeout_ipending) {
+ } else if ((s->ier & UART_IER_RDI) && s->timeout_ipending) {
tmp_iir = UART_IIR_CTI;
} else if ((s->ier & UART_IER_RDI) && (s->lsr & UART_LSR_DR)) {
if (!(s->fcr & UART_FCR_FE)) {
reply other threads:[~2008-09-17 0:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Kfkn4-0001R1-TT@cvs.savannah.gnu.org \
--to=balrogg@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).