From: Andrzej Zaborowski <balrogg@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [5264] Add a comment about masking of CTI interrupt in 16550A UART.
Date: Sat, 20 Sep 2008 01:15:06 +0000 [thread overview]
Message-ID: <E1Kgr3y-0006wA-Mo@cvs.savannah.gnu.org> (raw)
Revision: 5264
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5264
Author: balrog
Date: 2008-09-20 01:15:04 +0000 (Sat, 20 Sep 2008)
Log Message:
-----------
Add a comment about masking of CTI interrupt in 16550A UART.
Modified Paths:
--------------
trunk/hw/serial.c
Modified: trunk/hw/serial.c
===================================================================
--- trunk/hw/serial.c 2008-09-20 01:10:32 UTC (rev 5263)
+++ trunk/hw/serial.c 2008-09-20 01:15:04 UTC (rev 5264)
@@ -192,6 +192,9 @@
if ((s->ier & UART_IER_RLSI) && (s->lsr & UART_LSR_INT_ANY)) {
tmp_iir = UART_IIR_RLSI;
} else if ((s->ier & UART_IER_RDI) && s->timeout_ipending) {
+ /* Note that(s->ier & UART_IER_RDI) can mask this interrupt,
+ * this is not in the specification but is observed on existing
+ * hardware. */
tmp_iir = UART_IIR_CTI;
} else if ((s->ier & UART_IER_RDI) && (s->lsr & UART_LSR_DR)) {
if (!(s->fcr & UART_FCR_FE)) {
reply other threads:[~2008-09-20 1:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Kgr3y-0006wA-Mo@cvs.savannah.gnu.org \
--to=balrogg@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).