From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kgr44-0001X8-DW
	for qemu-devel@nongnu.org; Fri, 19 Sep 2008 21:15:12 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kgr43-0001Wj-OL
	for qemu-devel@nongnu.org; Fri, 19 Sep 2008 21:15:12 -0400
Received: from [199.232.76.173] (port=34355 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kgr43-0001Wg-Kn
	for qemu-devel@nongnu.org; Fri, 19 Sep 2008 21:15:11 -0400
Received: from savannah.gnu.org ([199.232.41.3]:39286 helo=sv.gnu.org)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <INVALID.NOREPLY@gnu.org>)
	id 1Kgr43-0005bF-Ob
	for qemu-devel@nongnu.org; Fri, 19 Sep 2008 21:15:11 -0400
Received: from cvs.savannah.gnu.org ([199.232.41.69])
	by sv.gnu.org with esmtp (Exim 4.63)
	(envelope-from <INVALID.NOREPLY@gnu.org>) id 1Kgr40-0006wm-P2
	for qemu-devel@nongnu.org; Sat, 20 Sep 2008 01:15:09 +0000
Received: from balrog by cvs.savannah.gnu.org with local (Exim 4.63)
	(envelope-from <balrog@savannah.gnu.org>) id 1Kgr3y-0006wA-Mo
	for qemu-devel@nongnu.org; Sat, 20 Sep 2008 01:15:07 +0000
MIME-Version: 1.0
Errors-To: balrog
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Andrzej Zaborowski <balrogg@gmail.com>
Message-Id: <E1Kgr3y-0006wA-Mo@cvs.savannah.gnu.org>
Date: Sat, 20 Sep 2008 01:15:06 +0000
Subject: [Qemu-devel] [5264] Add a comment about masking of CTI interrupt in
	16550A UART.
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Revision: 5264
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5264
Author:   balrog
Date:     2008-09-20 01:15:04 +0000 (Sat, 20 Sep 2008)

Log Message:
-----------
Add a comment about masking of CTI interrupt in 16550A UART.

Modified Paths:
--------------
    trunk/hw/serial.c

Modified: trunk/hw/serial.c
===================================================================
--- trunk/hw/serial.c	2008-09-20 01:10:32 UTC (rev 5263)
+++ trunk/hw/serial.c	2008-09-20 01:15:04 UTC (rev 5264)
@@ -192,6 +192,9 @@
     if ((s->ier & UART_IER_RLSI) && (s->lsr & UART_LSR_INT_ANY)) {
         tmp_iir = UART_IIR_RLSI;
     } else if ((s->ier & UART_IER_RDI) && s->timeout_ipending) {
+        /* Note that(s->ier & UART_IER_RDI) can mask this interrupt,
+         * this is not in the specification but is observed on existing
+         * hardware.  */
         tmp_iir = UART_IIR_CTI;
     } else if ((s->ier & UART_IER_RDI) && (s->lsr & UART_LSR_DR)) {
         if (!(s->fcr & UART_FCR_FE)) {