From: Paul Brook <paul@nowt.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [5286] Fix ARM NEON vdup and vtbl bugs.
Date: Mon, 22 Sep 2008 00:52:43 +0000 [thread overview]
Message-ID: <E1KhZfP-0001GE-Ry@cvs.savannah.gnu.org> (raw)
Revision: 5286
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5286
Author: pbrook
Date: 2008-09-22 00:52:42 +0000 (Mon, 22 Sep 2008)
Log Message:
-----------
Fix ARM NEON vdup and vtbl bugs.
Signed-off-by: Paul Brook <paul@codesourcery.com>
Modified Paths:
--------------
trunk/target-arm/op_helper.c
trunk/target-arm/translate.c
Modified: trunk/target-arm/op_helper.c
===================================================================
--- trunk/target-arm/op_helper.c 2008-09-21 23:15:38 UTC (rev 5285)
+++ trunk/target-arm/op_helper.c 2008-09-22 00:52:42 UTC (rev 5286)
@@ -56,7 +56,7 @@
for (shift = 0; shift < 32; shift += 8) {
index = (ireg >> shift) & 0xff;
if (index < maxindex) {
- tmp = (table[index >> 3] >> (index & 7)) & 0xff;
+ tmp = (table[index >> 3] >> ((index & 7) << 3)) & 0xff;
val |= tmp << shift;
} else {
val |= def & (0xff << shift);
Modified: trunk/target-arm/translate.c
===================================================================
--- trunk/target-arm/translate.c 2008-09-21 23:15:38 UTC (rev 5285)
+++ trunk/target-arm/translate.c 2008-09-22 00:52:42 UTC (rev 5286)
@@ -2807,7 +2807,7 @@
tmp2 = new_tmp();
tcg_gen_mov_i32(tmp2, tmp);
neon_store_reg(rn, 0, tmp2);
- neon_store_reg(rn, 0, tmp);
+ neon_store_reg(rn, 1, tmp);
} else {
/* VMOV */
switch (size) {
@@ -3814,7 +3814,7 @@
tmp2 = new_tmp();
tcg_gen_mov_i32(tmp2, tmp);
neon_store_reg(rd, 0, tmp2);
- neon_store_reg(rd, 0, tmp);
+ neon_store_reg(rd, 1, tmp);
rd += stride;
}
stride = (1 << size) * nregs;
@@ -5498,7 +5498,7 @@
}
} else if ((insn & (1 << 10)) == 0) {
/* VTBL, VTBX. */
- n = (insn >> 5) & 0x18;
+ n = ((insn >> 5) & 0x18) + 8;
if (insn & (1 << 6)) {
tmp = neon_load_reg(rd, 0);
} else {
@@ -5508,6 +5508,7 @@
tmp2 = neon_load_reg(rm, 0);
gen_helper_neon_tbl(tmp2, tmp2, tmp, tcg_const_i32(rn),
tcg_const_i32(n));
+ dead_tmp(tmp);
if (insn & (1 << 6)) {
tmp = neon_load_reg(rd, 1);
} else {
@@ -5518,7 +5519,8 @@
gen_helper_neon_tbl(tmp3, tmp3, tmp, tcg_const_i32(rn),
tcg_const_i32(n));
neon_store_reg(rd, 0, tmp2);
- neon_store_reg(rd, 1, tmp2);
+ neon_store_reg(rd, 1, tmp3);
+ dead_tmp(tmp);
} else if ((insn & 0x380) == 0) {
/* VDUP */
if (insn & (1 << 19)) {
reply other threads:[~2008-09-22 0:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1KhZfP-0001GE-Ry@cvs.savannah.gnu.org \
--to=paul@nowt.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).