From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Khy5J-0001IG-AZ for qemu-devel@nongnu.org; Mon, 22 Sep 2008 22:57:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Khy5G-0001H6-T6 for qemu-devel@nongnu.org; Mon, 22 Sep 2008 22:57:03 -0400 Received: from [199.232.76.173] (port=41745 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Khy5G-0001Gk-L2 for qemu-devel@nongnu.org; Mon, 22 Sep 2008 22:57:02 -0400 Received: from savannah.gnu.org ([199.232.41.3]:43687 helo=sv.gnu.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Khy5G-00080f-9r for qemu-devel@nongnu.org; Mon, 22 Sep 2008 22:57:02 -0400 Received: from cvs.savannah.gnu.org ([199.232.41.69]) by sv.gnu.org with esmtp (Exim 4.63) (envelope-from ) id 1Khy5F-0003aC-QT for qemu-devel@nongnu.org; Tue, 23 Sep 2008 02:57:01 +0000 Received: from aliguori by cvs.savannah.gnu.org with local (Exim 4.63) (envelope-from ) id 1Khy5F-0003a3-G0 for qemu-devel@nongnu.org; Tue, 23 Sep 2008 02:57:01 +0000 MIME-Version: 1.0 Errors-To: aliguori Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Anthony Liguori Message-Id: Date: Tue, 23 Sep 2008 02:57:01 +0000 Subject: [Qemu-devel] [5304] Relax posix-aio restrictions on newer glibcs Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Revision: 5304 http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5304 Author: aliguori Date: 2008-09-23 02:57:00 +0000 (Tue, 23 Sep 2008) Log Message: ----------- Relax posix-aio restrictions on newer glibcs RedHat 9 shipped glibc 2.3. Modern versions of glibc do not have the aio thread exit issue that the comment references. This patch adjusts the check to only limit aio_init on glibc versions < 2.4. Signed-off-by: Anthony Liguori Modified Paths: -------------- trunk/block-raw-posix.c Modified: trunk/block-raw-posix.c =================================================================== --- trunk/block-raw-posix.c 2008-09-22 21:54:00 UTC (rev 5303) +++ trunk/block-raw-posix.c 2008-09-23 02:57:00 UTC (rev 5304) @@ -545,7 +545,7 @@ qemu_aio_set_fd_handler(s->fd, posix_aio_read, NULL, posix_aio_flush, s); -#if defined(__GLIBC__) && defined(__linux__) +#if defined(__linux__) && defined(__GLIBC_PREREQ) && !__GLIBC_PREREQ(2, 4) { /* XXX: aio thread exit seems to hang on RedHat 9 and this init seems to fix the problem. */