From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KiV4k-0001Hx-C1 for qemu-devel@nongnu.org; Wed, 24 Sep 2008 10:10:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KiV4i-0001HJ-Nx for qemu-devel@nongnu.org; Wed, 24 Sep 2008 10:10:42 -0400 Received: from [199.232.76.173] (port=56584 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KiV4i-0001HD-JR for qemu-devel@nongnu.org; Wed, 24 Sep 2008 10:10:40 -0400 Received: from savannah.gnu.org ([199.232.41.3]:35310 helo=sv.gnu.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KiV4i-0007pQ-1V for qemu-devel@nongnu.org; Wed, 24 Sep 2008 10:10:40 -0400 Received: from cvs.savannah.gnu.org ([199.232.41.69]) by sv.gnu.org with esmtp (Exim 4.63) (envelope-from ) id 1KiV4f-0003Fr-KM for qemu-devel@nongnu.org; Wed, 24 Sep 2008 14:10:37 +0000 Received: from aliguori by cvs.savannah.gnu.org with local (Exim 4.63) (envelope-from ) id 1KiV4f-0003Fn-BJ for qemu-devel@nongnu.org; Wed, 24 Sep 2008 14:10:37 +0000 MIME-Version: 1.0 Errors-To: aliguori Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Anthony Liguori Message-Id: Date: Wed, 24 Sep 2008 14:10:37 +0000 Subject: [Qemu-devel] [5310] 64 bit truncation in code_gen_buffer_size calculation (Jes Sorensen) Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Revision: 5310 http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5310 Author: aliguori Date: 2008-09-24 14:10:36 +0000 (Wed, 24 Sep 2008) Log Message: ----------- 64 bit truncation in code_gen_buffer_size calculation (Jes Sorensen) Don't truncate code_gen_buffer_size calculation to int, as it will give unpredicted results on 64 bit systems when booting large guests. Signed-off-by: Jes Sorensen Signed-off-by: Anthony Liguori Modified Paths: -------------- trunk/exec.c Modified: trunk/exec.c =================================================================== --- trunk/exec.c 2008-09-24 03:32:33 UTC (rev 5309) +++ trunk/exec.c 2008-09-24 14:10:36 UTC (rev 5310) @@ -410,7 +410,7 @@ code_gen_buffer_size = DEFAULT_CODE_GEN_BUFFER_SIZE; #else /* XXX: needs ajustments */ - code_gen_buffer_size = (int)(phys_ram_size / 4); + code_gen_buffer_size = (unsigned long)(phys_ram_size / 4); #endif } if (code_gen_buffer_size < MIN_CODE_GEN_BUFFER_SIZE)