[Qemu-devel] [5391] ppc: fix crash in ppc system single step support

[Qemu-devel] [5391] ppc: fix crash in ppc system single step support

[Aurelien Jarno]

Revision: 5391
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5391
Author:   aurel32
Date:     2008-10-01 22:01:37 +0000 (Wed, 01 Oct 2008)

Log Message:
-----------
ppc: fix crash in ppc system single step support

There was a bogus case where two system debug ops get generated.  This
patch removes the broken system debug op. This was a left over after
making some changes to correctly generate debug ops on branch
operations inside gen_goto_tb();

The test case against this patch is to turn on single stepping with
timers, boot a linux kernel, set a breakpoint a do_fork and in gdb
execute "si 3000".  Then qemu-system-ppc will fault executing a debug
op, which should not have been executed.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

Modified Paths:
--------------
    trunk/target-ppc/translate.c

Modified: trunk/target-ppc/translate.c
===================================================================
--- trunk/target-ppc/translate.c	2008-10-01 22:01:28 UTC (rev 5390)
+++ trunk/target-ppc/translate.c	2008-10-01 22:01:37 UTC (rev 5391)
@@ -3048,10 +3048,6 @@
 #endif
             gen_op_btest_T1(ctx->nip);
     no_test:
-        if (ctx->singlestep_enabled & GDBSTUB_SINGLE_STEP) {
-            gen_update_nip(ctx, ctx->nip);
-            gen_op_debug();
-        }
         tcg_gen_exit_tb(0);
     }
 }