From: Andrzej Zaborowski <balrogg@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [5409] Reset CFI01 flash wcycle after erase confirm (Thomas Petazzoni).
Date: Fri, 03 Oct 2008 23:00:16 +0000 [thread overview]
Message-ID: <E1KltdA-0007YH-S5@cvs.savannah.gnu.org> (raw)
Revision: 5409
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5409
Author: balrog
Date: 2008-10-03 23:00:09 +0000 (Fri, 03 Oct 2008)
Log Message:
-----------
Reset CFI01 flash wcycle after erase confirm (Thomas Petazzoni).
pfl->wcycle was set to 1 when the erase confirm command was set, which
lead to the next command being misinterpreted by Qemu:
pflash_write: Unimplemented flash cmd sequence (offset 00000000,
wcycle 0x1 cmd 0x20 value 0x70)
This patch fixes this issue by resetting pfl->wcycle to 0 on erase
confirm so that the next command is considered as a new one.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Modified Paths:
--------------
trunk/hw/pflash_cfi01.c
Modified: trunk/hw/pflash_cfi01.c
===================================================================
--- trunk/hw/pflash_cfi01.c 2008-10-03 19:04:42 UTC (rev 5408)
+++ trunk/hw/pflash_cfi01.c 2008-10-03 23:00:09 UTC (rev 5409)
@@ -267,7 +267,7 @@
case 0x20: /* Block erase */
case 0x28:
if (cmd == 0xd0) { /* confirm */
- pfl->wcycle = 1;
+ pfl->wcycle = 0;
pfl->status |= 0x80;
} else if (cmd == 0xff) { /* read array mode */
goto reset_flash;
reply other threads:[~2008-10-03 23:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1KltdA-0007YH-S5@cvs.savannah.gnu.org \
--to=balrogg@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).