* [Qemu-devel] [5409] Reset CFI01 flash wcycle after erase confirm (Thomas Petazzoni).
@ 2008-10-03 23:00 Andrzej Zaborowski
0 siblings, 0 replies; only message in thread
From: Andrzej Zaborowski @ 2008-10-03 23:00 UTC (permalink / raw)
To: qemu-devel
Revision: 5409
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5409
Author: balrog
Date: 2008-10-03 23:00:09 +0000 (Fri, 03 Oct 2008)
Log Message:
-----------
Reset CFI01 flash wcycle after erase confirm (Thomas Petazzoni).
pfl->wcycle was set to 1 when the erase confirm command was set, which
lead to the next command being misinterpreted by Qemu:
pflash_write: Unimplemented flash cmd sequence (offset 00000000,
wcycle 0x1 cmd 0x20 value 0x70)
This patch fixes this issue by resetting pfl->wcycle to 0 on erase
confirm so that the next command is considered as a new one.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Modified Paths:
--------------
trunk/hw/pflash_cfi01.c
Modified: trunk/hw/pflash_cfi01.c
===================================================================
--- trunk/hw/pflash_cfi01.c 2008-10-03 19:04:42 UTC (rev 5408)
+++ trunk/hw/pflash_cfi01.c 2008-10-03 23:00:09 UTC (rev 5409)
@@ -267,7 +267,7 @@
case 0x20: /* Block erase */
case 0x28:
if (cmd == 0xd0) { /* confirm */
- pfl->wcycle = 1;
+ pfl->wcycle = 0;
pfl->status |= 0x80;
} else if (cmd == 0xff) { /* read array mode */
goto reset_flash;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-10-03 23:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-03 23:00 [Qemu-devel] [5409] Reset CFI01 flash wcycle after erase confirm (Thomas Petazzoni) Andrzej Zaborowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).