From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [5465] hw/apic.c: use __builtin funtions instead of assembly code
Date: Sun, 12 Oct 2008 00:53:17 +0000 [thread overview]
Message-ID: <E1KopCv-0001X3-Qp@cvs.savannah.gnu.org> (raw)
Revision: 5465
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5465
Author: aurel32
Date: 2008-10-12 00:53:17 +0000 (Sun, 12 Oct 2008)
Log Message:
-----------
hw/apic.c: use __builtin funtions instead of assembly code
Suggested by malc.
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Modified Paths:
--------------
trunk/hw/apic.c
Modified: trunk/hw/apic.c
===================================================================
--- trunk/hw/apic.c 2008-10-12 00:53:08 UTC (rev 5464)
+++ trunk/hw/apic.c 2008-10-12 00:53:17 UTC (rev 5465)
@@ -104,15 +104,14 @@
static void apic_set_irq(APICState *s, int vector_num, int trigger_mode);
static void apic_update_irq(APICState *s);
-/* Find first bit starting from msb. Return 0 if value = 0 */
+/* Find first bit starting from msb */
static int fls_bit(uint32_t value)
{
+#if defined(__GNUC__)
+ return 31 - __builtin_clz(value);
+#else
unsigned int ret = 0;
-#if defined(HOST_I386) || defined(HOST_X86_64)
- __asm__ __volatile__ ("bsr %1, %0\n" : "+r" (ret) : "rm" (value));
- return ret;
-#else
if (value > 0xffff)
value >>= 16, ret = 16;
if (value > 0xff)
@@ -125,15 +124,14 @@
#endif
}
-/* Find first bit starting from lsb. Return 0 if value = 0 */
+/* Find first bit starting from lsb */
static int ffs_bit(uint32_t value)
{
+#if defined(__GNUC__)
+ return __builtin_ffs(value) - 1;
+#else
unsigned int ret = 0;
-#if defined(HOST_I386) || defined(HOST_X86_64)
- __asm__ __volatile__ ("bsf %1, %0\n" : "+r" (ret) : "rm" (value));
- return ret;
-#else
if (!value)
return 0;
if (!(value & 0xffff))
next reply other threads:[~2008-10-12 0:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-12 0:53 Aurelien Jarno [this message]
2008-10-12 10:21 ` [Qemu-devel] Re: [5465] hw/apic.c: use __builtin funtions instead of assembly code Jan Kiszka
2008-10-12 11:44 ` Aurelien Jarno
2008-10-12 19:17 ` [Qemu-devel] " Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1KopCv-0001X3-Qp@cvs.savannah.gnu.org \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).