From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KpUec-0000Iv-Dk
	for qemu-devel@nongnu.org; Mon, 13 Oct 2008 17:08:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KpUea-0000HK-Nr
	for qemu-devel@nongnu.org; Mon, 13 Oct 2008 17:08:37 -0400
Received: from [199.232.76.173] (port=52389 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KpUea-0000H5-Ej
	for qemu-devel@nongnu.org; Mon, 13 Oct 2008 17:08:36 -0400
Received: from savannah.gnu.org ([199.232.41.3]:43504 helo=sv.gnu.org)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <INVALID.NOREPLY@gnu.org>)
	id 1KpUeZ-0005lq-UJ
	for qemu-devel@nongnu.org; Mon, 13 Oct 2008 17:08:36 -0400
Received: from cvs.savannah.gnu.org ([199.232.41.69])
	by sv.gnu.org with esmtp (Exim 4.63)
	(envelope-from <INVALID.NOREPLY@gnu.org>) id 1KpUeZ-0006ab-2d
	for qemu-devel@nongnu.org; Mon, 13 Oct 2008 21:08:35 +0000
Received: from aurel32 by cvs.savannah.gnu.org with local (Exim 4.63)
	(envelope-from <aurel32@savannah.gnu.org>) id 1KpUeY-0006aW-Rz
	for qemu-devel@nongnu.org; Mon, 13 Oct 2008 21:08:34 +0000
MIME-Version: 1.0
Errors-To: aurel32
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Aurelien Jarno <aurelien@aurel32.net>
Message-Id: <E1KpUeY-0006aW-Rz@cvs.savannah.gnu.org>
Date: Mon, 13 Oct 2008 21:08:34 +0000
Subject: [Qemu-devel] [5482] open() can also return EPERM for O_RDWR on a
	readonly device
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Revision: 5482
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5482
Author:   aurel32
Date:     2008-10-13 21:08:34 +0000 (Mon, 13 Oct 2008)

Log Message:
-----------
open() can also return EPERM for O_RDWR on a readonly device

Signed-off-by: Juergen Lock <nox@jelal.kn-bremen.de>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

Modified Paths:
--------------
    trunk/block.c

Modified: trunk/block.c
===================================================================
--- trunk/block.c	2008-10-13 21:08:25 UTC (rev 5481)
+++ trunk/block.c	2008-10-13 21:08:34 UTC (rev 5482)
@@ -399,7 +399,7 @@
     else
         open_flags = flags & ~(BDRV_O_FILE | BDRV_O_SNAPSHOT);
     ret = drv->bdrv_open(bs, filename, open_flags);
-    if (ret == -EACCES && !(flags & BDRV_O_FILE)) {
+    if ((ret == -EACCES || ret == -EPERM) && !(flags & BDRV_O_FILE)) {
         ret = drv->bdrv_open(bs, filename, BDRV_O_RDONLY);
         bs->read_only = 1;
     }