[Qemu-devel] [5530] Fix undefined pthread_sigmask warning on OpenBSD

[Qemu-devel] [5530] Fix undefined pthread_sigmask warning on OpenBSD

[Blue Swirl]

Revision: 5530
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5530
Author:   blueswir1
Date:     2008-10-25 11:19:14 +0000 (Sat, 25 Oct 2008)

Log Message:
-----------
Fix undefined pthread_sigmask warning on OpenBSD

Modified Paths:
--------------
    trunk/audio/sdlaudio.c

Modified: trunk/audio/sdlaudio.c
===================================================================
--- trunk/audio/sdlaudio.c	2008-10-25 11:18:12 UTC (rev 5529)
+++ trunk/audio/sdlaudio.c	2008-10-25 11:19:14 UTC (rev 5530)
@@ -29,6 +29,8 @@
 #ifndef _WIN32
 #ifdef __sun__
 #define _POSIX_PTHREAD_SEMANTICS 1
+#elif defined(__OpenBSD__)
+#include <pthread.h>
 #endif
 #include <signal.h>
 #endif

Re: [Qemu-devel] [5530] Fix undefined pthread_sigmask warning on OpenBSD

[Juergen Lock]

Hi!

In article <E1KthAo-0006G1-Pq@cvs.savannah.gnu.org> you write:
>Revision: 5530
>          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5530
>Author:   blueswir1
>Date:     2008-10-25 11:19:14 +0000 (Sat, 25 Oct 2008)
>
>Log Message:
>-----------
>Fix undefined pthread_sigmask warning on OpenBSD
>
>Modified Paths:
>--------------
>    trunk/audio/sdlaudio.c
>
>Modified: trunk/audio/sdlaudio.c
>===================================================================
>--- trunk/audio/sdlaudio.c	2008-10-25 11:18:12 UTC (rev 5529)
>+++ trunk/audio/sdlaudio.c	2008-10-25 11:19:14 UTC (rev 5530)
>@@ -29,6 +29,8 @@
> #ifndef _WIN32
> #ifdef __sun__
> #define _POSIX_PTHREAD_SEMANTICS 1
>+#elif defined(__OpenBSD__)
>+#include <pthread.h>
> #endif
> #include <signal.h>
> #endif
>
 I forgot to mention that I also patched this for FreeBSD, so the above

>+#elif defined(__OpenBSD__)

 can be changed to

>+#elif defined(__OpenBSD__) || defined(__FreeBSD__)

 Or do I need to send a proper patch? :)

 Thanx,
	Juergen

Re: [Qemu-devel] [5530] Fix undefined pthread_sigmask warning on OpenBSD

[Blue Swirl]

On 10/25/08, Juergen Lock <nox@jelal.kn-bremen.de> wrote:
> Hi!
>
>
>  In article <E1KthAo-0006G1-Pq@cvs.savannah.gnu.org> you write:
>  >Revision: 5530
>  >          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5530
>  >Author:   blueswir1
>  >Date:     2008-10-25 11:19:14 +0000 (Sat, 25 Oct 2008)
>  >
>  >Log Message:
>  >-----------
>  >Fix undefined pthread_sigmask warning on OpenBSD
>  >
>  >Modified Paths:
>  >--------------
>  >    trunk/audio/sdlaudio.c
>  >
>  >Modified: trunk/audio/sdlaudio.c
>  >===================================================================
>  >--- trunk/audio/sdlaudio.c     2008-10-25 11:18:12 UTC (rev 5529)
>  >+++ trunk/audio/sdlaudio.c     2008-10-25 11:19:14 UTC (rev 5530)
>  >@@ -29,6 +29,8 @@
>  > #ifndef _WIN32
>  > #ifdef __sun__
>  > #define _POSIX_PTHREAD_SEMANTICS 1
>  >+#elif defined(__OpenBSD__)
>  >+#include <pthread.h>
>  > #endif
>  > #include <signal.h>
>  > #endif
>  >
>
>  I forgot to mention that I also patched this for FreeBSD, so the above
>
>  >+#elif defined(__OpenBSD__)
>
>   can be changed to
>
>  >+#elif defined(__OpenBSD__) || defined(__FreeBSD__)
>
>   Or do I need to send a proper patch? :)

No, I'll just copy and paste. It looks like NetBSD uses signal.h like
everyone should.

http://www.opengroup.org/onlinepubs/009695399/functions/pthread_sigmask.html

http://cvsweb.netbsd.org/bsdweb.cgi/src/include/signal.h?rev=1.50&content-type=text/x-cvsweb-markup&only_with_tag=MAIN