qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [5567] fix off-by-one generating vmdk backing files (Avi Kivity)
Date: Tue, 28 Oct 2008 14:08:49 +0000	[thread overview]
Message-ID: <E1KupFZ-0001QB-LY@cvs.savannah.gnu.org> (raw)

Revision: 5567
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5567
Author:   aliguori
Date:     2008-10-28 14:08:49 +0000 (Tue, 28 Oct 2008)

Log Message:
-----------
fix off-by-one generating vmdk backing files (Avi Kivity)

Signed-off-by: Avi Kivity <avi@redhat.com> 
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Modified Paths:
--------------
    trunk/block-vmdk.c

Modified: trunk/block-vmdk.c
===================================================================
--- trunk/block-vmdk.c	2008-10-28 10:59:59 UTC (rev 5566)
+++ trunk/block-vmdk.c	2008-10-28 14:08:49 UTC (rev 5567)
@@ -344,7 +344,7 @@
         if ((end_name - p_name) > sizeof (s->hd->backing_file) - 1)
             return -1;
 
-        pstrcpy(s->hd->backing_file, end_name - p_name, p_name);
+        pstrcpy(s->hd->backing_file, end_name - p_name + 1, p_name);
         if (stat(s->hd->backing_file, &file_buf) != 0) {
             path_combine(parent_img_name, sizeof(parent_img_name),
                          filename, s->hd->backing_file);

                 reply	other threads:[~2008-10-28 14:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1KupFZ-0001QB-LY@cvs.savannah.gnu.org \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).