From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [5570] Fix restore of older snapshots for target-i386 on big endian hosts
Date: Wed, 29 Oct 2008 14:16:33 +0000 [thread overview]
Message-ID: <E1KvBqb-0001ux-3g@cvs.savannah.gnu.org> (raw)
Revision: 5570
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5570
Author: aliguori
Date: 2008-10-29 14:16:31 +0000 (Wed, 29 Oct 2008)
Log Message:
-----------
Fix restore of older snapshots for target-i386 on big endian hosts
A target_ulong may be 64-bit. Passing it to a function expecting a 32-bit
pointer is wrong and unfortunately happens to work for x86. It won't work on
big endian hosts though. Change the code to work properly on all hosts.
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Modified Paths:
--------------
trunk/target-i386/machine.c
Modified: trunk/target-i386/machine.c
===================================================================
--- trunk/target-i386/machine.c 2008-10-28 18:22:59 UTC (rev 5569)
+++ trunk/target-i386/machine.c 2008-10-29 14:16:31 UTC (rev 5570)
@@ -248,8 +248,8 @@
qemu_get_betls(f, &env->sysenter_esp);
qemu_get_betls(f, &env->sysenter_eip);
} else {
- qemu_get_be32s(f, &env->sysenter_esp);
- qemu_get_be32s(f, &env->sysenter_eip);
+ env->sysenter_esp = qemu_get_be32(f);
+ env->sysenter_eip = qemu_get_be32(f);
}
qemu_get_betls(f, &env->cr[0]);
reply other threads:[~2008-10-29 14:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1KvBqb-0001ux-3g@cvs.savannah.gnu.org \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).