* [Qemu-devel] [5667] target-alpha: fix cmpbge instruction
@ 2008-11-10 11:10 Aurelien Jarno
0 siblings, 0 replies; only message in thread
From: Aurelien Jarno @ 2008-11-10 11:10 UTC (permalink / raw)
To: qemu-devel
Revision: 5667
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5667
Author: aurel32
Date: 2008-11-10 11:10:14 +0000 (Mon, 10 Nov 2008)
Log Message:
-----------
target-alpha: fix cmpbge instruction
The cmpbge instruction should compare all 8 bytes of one 64-bit value with
another. However, we were looping with a < 7 condition which was skipping
the top byte. So if we were doing a compare where the top byte was
important, we could get the wrong result (this notably breaks the strlen()
function with certain sized strings).
(Vince Weaver)
Modified Paths:
--------------
trunk/target-alpha/op_helper.c
Modified: trunk/target-alpha/op_helper.c
===================================================================
--- trunk/target-alpha/op_helper.c 2008-11-10 02:55:33 UTC (rev 5666)
+++ trunk/target-alpha/op_helper.c 2008-11-10 11:10:14 UTC (rev 5667)
@@ -330,7 +330,7 @@
int i;
res = 0;
- for (i = 0; i < 7; i++) {
+ for (i = 0; i < 8; i++) {
opa = op1 >> (i * 8);
opb = op2 >> (i * 8);
if (opa >= opb)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-11-10 11:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-10 11:10 [Qemu-devel] [5667] target-alpha: fix cmpbge instruction Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).