qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [5703] Fix -linux-user build by reverting r5701
Date: Tue, 11 Nov 2008 22:06:43 +0000	[thread overview]
Message-ID: <E1L01Nj-0003om-0f@cvs.savannah.gnu.org> (raw)

Revision: 5703
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5703
Author:   aliguori
Date:     2008-11-11 22:06:42 +0000 (Tue, 11 Nov 2008)

Log Message:
-----------
Fix -linux-user build by reverting r5701

Unfortunately, -linux-user doesn't use osdep as it replaces some of those
functions with specific ones.  The code #ifdef code in exec.c needs to
remain in place so instead of introducing a qemu_getpagesize() let's just
use getpagesize() in the non-Windows implementation of qemu_vmalloc.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Modified Paths:
--------------
    trunk/exec.c
    trunk/osdep.c
    trunk/osdep.h

Modified: trunk/exec.c
===================================================================
--- trunk/exec.c	2008-11-11 21:50:17 UTC (rev 5702)
+++ trunk/exec.c	2008-11-11 22:06:42 UTC (rev 5703)
@@ -231,7 +231,16 @@
 {
     /* NOTE: we can always suppose that qemu_host_page_size >=
        TARGET_PAGE_SIZE */
-    qemu_real_host_page_size = qemu_getpagesize();
+#ifdef _WIN32
+    {
+        SYSTEM_INFO system_info;
+
+        GetSystemInfo(&system_info);
+        qemu_real_host_page_size = system_info.dwPageSize;
+    }
+#else
+    qemu_real_host_page_size = getpagesize();
+#endif
     if (qemu_host_page_size == 0)
         qemu_host_page_size = qemu_real_host_page_size;
     if (qemu_host_page_size < TARGET_PAGE_SIZE)

Modified: trunk/osdep.c
===================================================================
--- trunk/osdep.c	2008-11-11 21:50:17 UTC (rev 5702)
+++ trunk/osdep.c	2008-11-11 22:06:42 UTC (rev 5703)
@@ -66,14 +66,6 @@
     VirtualFree(ptr, 0, MEM_RELEASE);
 }
 
-long qemu_getpagesize(void)
-{
-    SYSTEM_INFO system_info;
-
-    GetSystemInfo(&system_info);
-    return system_info.dwPageSize;
-}
-
 #else
 
 #if defined(USE_KQEMU)
@@ -198,11 +190,6 @@
 #endif
 }
 
-long qemu_getpagesize(void)
-{
-    return sysconf(_SC_PAGESIZE);
-}
-
 /* alloc shared memory pages */
 void *qemu_vmalloc(size_t size)
 {
@@ -213,7 +200,7 @@
 #ifdef _BSD
     return valloc(size);
 #else
-    return memalign(qemu_getpagesize(), size);
+    return memalign(getpagesize(), size);
 #endif
 }
 

Modified: trunk/osdep.h
===================================================================
--- trunk/osdep.h	2008-11-11 21:50:17 UTC (rev 5702)
+++ trunk/osdep.h	2008-11-11 22:06:42 UTC (rev 5703)
@@ -72,7 +72,6 @@
 void *qemu_memalign(size_t alignment, size_t size);
 void *qemu_vmalloc(size_t size);
 void qemu_vfree(void *ptr);
-long qemu_getpagesize(void);
 
 int qemu_create_pidfile(const char *filename);
 

                 reply	other threads:[~2008-11-11 22:06 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1L01Nj-0003om-0f@cvs.savannah.gnu.org \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).