From: Andrzej Zaborowski <balrogg@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [5707] r5531 made x509 certs not loadable (original patch from Henrik Holst ).
Date: Wed, 12 Nov 2008 16:50:36 +0000 [thread overview]
Message-ID: <E1L0IvM-0000DJ-MY@cvs.savannah.gnu.org> (raw)
Revision: 5707
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5707
Author: balrog
Date: 2008-11-12 16:50:36 +0000 (Wed, 12 Nov 2008)
Log Message:
-----------
r5531 made x509 certs not loadable (original patch from Henrik Holst).
The patch in r5531 which replaced a bunch of strncpy with pstrcpy causes
the x509 credentials from the -vnc parameter to be one character shorter
than entered meaning that there is currently no way to enter x509
certificates...
Modified Paths:
--------------
trunk/vnc.c
Modified: trunk/vnc.c
===================================================================
--- trunk/vnc.c 2008-11-12 16:41:32 UTC (rev 5706)
+++ trunk/vnc.c 2008-11-12 16:50:36 UTC (rev 5707)
@@ -2329,10 +2329,8 @@
end = strchr(options, ',');
if (start && (!end || (start < end))) {
int len = end ? end-(start+1) : strlen(start+1);
- char *path = qemu_malloc(len+1);
+ char *path = qemu_strndup(start + 1, len);
- pstrcpy(path, len, start + 1);
- path[len] = '\0';
VNC_DEBUG("Trying certificate path '%s'\n", path);
if (vnc_set_x509_credential_dir(vs, path) < 0) {
fprintf(stderr, "Failed to find x509 certificates/keys in %s\n", path);
reply other threads:[~2008-11-12 16:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1L0IvM-0000DJ-MY@cvs.savannah.gnu.org \
--to=balrogg@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).