From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [5713] Fix brown-paper-bag bugs from live-migration patch (Charles Duffy)
Date: Wed, 12 Nov 2008 22:29:12 +0000 [thread overview]
Message-ID: <E1L0OD2-0000Sf-Ea@cvs.savannah.gnu.org> (raw)
Revision: 5713
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5713
Author: aliguori
Date: 2008-11-12 22:29:11 +0000 (Wed, 12 Nov 2008)
Log Message:
-----------
Fix brown-paper-bag bugs from live-migration patch (Charles Duffy)
In TCP migration, prevent an endless loop trying to retrieve error status. In
exec migration, set the close pointer in the FdMigrationState structure.
Color me embarrassed.
Signed-off-by: Charles Duffy <charles_duffy@messageone.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Modified Paths:
--------------
trunk/migration-exec.c
trunk/migration-tcp.c
Modified: trunk/migration-exec.c
===================================================================
--- trunk/migration-exec.c 2008-11-12 20:36:27 UTC (rev 5712)
+++ trunk/migration-exec.c 2008-11-12 22:29:11 UTC (rev 5713)
@@ -85,6 +85,7 @@
s->opaque = qemu_popen(f, "w");
+ s->close = exec_close;
s->get_error = file_errno;
s->write = file_write;
s->mig_state.cancel = migrate_fd_cancel;
Modified: trunk/migration-tcp.c
===================================================================
--- trunk/migration-tcp.c 2008-11-12 20:36:27 UTC (rev 5712)
+++ trunk/migration-tcp.c 2008-11-12 22:29:11 UTC (rev 5713)
@@ -32,7 +32,7 @@
static int socket_errno(FdMigrationState *s)
{
- return (s->get_error(s));
+ return socket_error();
}
static int socket_write(FdMigrationState *s, const void * buf, size_t size)
reply other threads:[~2008-11-12 22:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1L0OD2-0000Sf-Ea@cvs.savannah.gnu.org \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).