qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [5723] target-mips: avoid tcg internal error in mfc0/dmfc0
Date: Sat, 15 Nov 2008 12:12:09 +0000	[thread overview]
Message-ID: <E1L1K0X-0003Ez-Lw@cvs.savannah.gnu.org> (raw)

Revision: 5723
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5723
Author:   aurel32
Date:     2008-11-15 12:12:08 +0000 (Sat, 15 Nov 2008)

Log Message:
-----------
target-mips: avoid tcg internal error in mfc0/dmfc0

Set t0 to 0 for unimplemented mfc0/dmfc0 instructions. This fixes a tcg
internal error while booting mips linux.

Noticed by Julia Longtin.

Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

Modified Paths:
--------------
    trunk/target-mips/translate.c

Modified: trunk/target-mips/translate.c
===================================================================
--- trunk/target-mips/translate.c	2008-11-14 17:20:15 UTC (rev 5722)
+++ trunk/target-mips/translate.c	2008-11-15 12:12:08 UTC (rev 5723)
@@ -3186,7 +3186,7 @@
         }
         break;
     case 22:
-        /* ignored */
+        tcg_gen_movi_tl(t0, 0); /* unimplemented */
         rn = "'Diagnostic"; /* implementation dependent */
         break;
     case 23:
@@ -3266,12 +3266,13 @@
         }
         break;
     case 26:
-       rn = "ECC";
-       break;
+        tcg_gen_movi_tl(t0, 0); /* unimplemented */
+        rn = "ECC";
+        break;
     case 27:
         switch (sel) {
-        /* ignored */
         case 0 ... 3:
+            tcg_gen_movi_tl(t0, 0); /* unimplemented */
             rn = "CacheErr";
             break;
         default:
@@ -4372,7 +4373,7 @@
         }
         break;
     case 22:
-        /* ignored */
+        tcg_gen_movi_tl(t0, 0); /* unimplemented */
         rn = "'Diagnostic"; /* implementation dependent */
         break;
     case 23:
@@ -4451,12 +4452,14 @@
         }
         break;
     case 26:
-       rn = "ECC";
-       break;
+        tcg_gen_movi_tl(t0, 0); /* unimplemented */
+        rn = "ECC";
+        break;
     case 27:
         switch (sel) {
         /* ignored */
         case 0 ... 3:
+            tcg_gen_movi_tl(t0, 0); /* unimplemented */
             rn = "CacheErr";
             break;
         default:
@@ -8013,7 +8016,7 @@
                 case OPC_EMT:
                     check_insn(env, ctx, ASE_MT);
                     tcg_gen_helper_1_1(do_emt, t0, t0);
-                     break;
+                    break;
                 case OPC_DVPE:
                     check_insn(env, ctx, ASE_MT);
                     tcg_gen_helper_1_1(do_dvpe, t0, t0);

                 reply	other threads:[~2008-11-15 12:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1L1K0X-0003Ez-Lw@cvs.savannah.gnu.org \
    --to=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).