From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L1K0a-0004hX-GJ
	for qemu-devel@nongnu.org; Sat, 15 Nov 2008 07:12:12 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L1K0Z-0004hL-0l
	for qemu-devel@nongnu.org; Sat, 15 Nov 2008 07:12:11 -0500
Received: from [199.232.76.173] (port=46028 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L1K0Y-0004hI-NX
	for qemu-devel@nongnu.org; Sat, 15 Nov 2008 07:12:10 -0500
Received: from savannah.gnu.org ([199.232.41.3]:42376 helo=sv.gnu.org)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <INVALID.NOREPLY@gnu.org>)
	id 1L1K0Y-0007zW-Gm
	for qemu-devel@nongnu.org; Sat, 15 Nov 2008 07:12:10 -0500
Received: from cvs.savannah.gnu.org ([199.232.41.69])
	by sv.gnu.org with esmtp (Exim 4.63)
	(envelope-from <INVALID.NOREPLY@gnu.org>) id 1L1K0Y-0003F4-2B
	for qemu-devel@nongnu.org; Sat, 15 Nov 2008 12:12:10 +0000
Received: from aurel32 by cvs.savannah.gnu.org with local (Exim 4.63)
	(envelope-from <aurel32@savannah.gnu.org>) id 1L1K0X-0003Ez-Lw
	for qemu-devel@nongnu.org; Sat, 15 Nov 2008 12:12:09 +0000
MIME-Version: 1.0
Errors-To: aurel32
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Aurelien Jarno <aurelien@aurel32.net>
Message-Id: <E1L1K0X-0003Ez-Lw@cvs.savannah.gnu.org>
Date: Sat, 15 Nov 2008 12:12:09 +0000
Subject: [Qemu-devel] [5723] target-mips: avoid tcg internal error in
	mfc0/dmfc0
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Revision: 5723
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5723
Author:   aurel32
Date:     2008-11-15 12:12:08 +0000 (Sat, 15 Nov 2008)

Log Message:
-----------
target-mips: avoid tcg internal error in mfc0/dmfc0

Set t0 to 0 for unimplemented mfc0/dmfc0 instructions. This fixes a tcg
internal error while booting mips linux.

Noticed by Julia Longtin.

Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

Modified Paths:
--------------
    trunk/target-mips/translate.c

Modified: trunk/target-mips/translate.c
===================================================================
--- trunk/target-mips/translate.c	2008-11-14 17:20:15 UTC (rev 5722)
+++ trunk/target-mips/translate.c	2008-11-15 12:12:08 UTC (rev 5723)
@@ -3186,7 +3186,7 @@
         }
         break;
     case 22:
-        /* ignored */
+        tcg_gen_movi_tl(t0, 0); /* unimplemented */
         rn = "'Diagnostic"; /* implementation dependent */
         break;
     case 23:
@@ -3266,12 +3266,13 @@
         }
         break;
     case 26:
-       rn = "ECC";
-       break;
+        tcg_gen_movi_tl(t0, 0); /* unimplemented */
+        rn = "ECC";
+        break;
     case 27:
         switch (sel) {
-        /* ignored */
         case 0 ... 3:
+            tcg_gen_movi_tl(t0, 0); /* unimplemented */
             rn = "CacheErr";
             break;
         default:
@@ -4372,7 +4373,7 @@
         }
         break;
     case 22:
-        /* ignored */
+        tcg_gen_movi_tl(t0, 0); /* unimplemented */
         rn = "'Diagnostic"; /* implementation dependent */
         break;
     case 23:
@@ -4451,12 +4452,14 @@
         }
         break;
     case 26:
-       rn = "ECC";
-       break;
+        tcg_gen_movi_tl(t0, 0); /* unimplemented */
+        rn = "ECC";
+        break;
     case 27:
         switch (sel) {
         /* ignored */
         case 0 ... 3:
+            tcg_gen_movi_tl(t0, 0); /* unimplemented */
             rn = "CacheErr";
             break;
         default:
@@ -8013,7 +8016,7 @@
                 case OPC_EMT:
                     check_insn(env, ctx, ASE_MT);
                     tcg_gen_helper_1_1(do_emt, t0, t0);
-                     break;
+                    break;
                 case OPC_DVPE:
                     check_insn(env, ctx, ASE_MT);
                     tcg_gen_helper_1_1(do_dvpe, t0, t0);