From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [5790] better type checking for vga (Glauber Costa)
Date: Mon, 24 Nov 2008 19:34:00 +0000 [thread overview]
Message-ID: <E1L4hC4-0000KM-AX@cvs.savannah.gnu.org> (raw)
Revision: 5790
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5790
Author: aliguori
Date: 2008-11-24 19:33:59 +0000 (Mon, 24 Nov 2008)
Log Message:
-----------
better type checking for vga (Glauber Costa)
unsigned long is too bad of a type. Use ram_addr_t instead.
aligurori: fixed a compile warning in this patch
Signed-off-by: Glauber Costa <glommer@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Modified Paths:
--------------
trunk/hw/cirrus_vga.c
trunk/hw/pc.h
trunk/hw/vga.c
trunk/hw/vga_int.h
Modified: trunk/hw/cirrus_vga.c
===================================================================
--- trunk/hw/cirrus_vga.c 2008-11-24 19:29:13 UTC (rev 5789)
+++ trunk/hw/cirrus_vga.c 2008-11-24 19:33:59 UTC (rev 5790)
@@ -3231,7 +3231,7 @@
***************************************/
void isa_cirrus_vga_init(DisplayState *ds, uint8_t *vga_ram_base,
- unsigned long vga_ram_offset, int vga_ram_size)
+ ram_addr_t vga_ram_offset, int vga_ram_size)
{
CirrusVGAState *s;
@@ -3273,7 +3273,7 @@
}
void pci_cirrus_vga_init(PCIBus *bus, DisplayState *ds, uint8_t *vga_ram_base,
- unsigned long vga_ram_offset, int vga_ram_size)
+ ram_addr_t vga_ram_offset, int vga_ram_size)
{
PCICirrusVGAState *d;
uint8_t *pci_conf;
Modified: trunk/hw/pc.h
===================================================================
--- trunk/hw/pc.h 2008-11-24 19:29:13 UTC (rev 5789)
+++ trunk/hw/pc.h 2008-11-24 19:33:59 UTC (rev 5790)
@@ -134,9 +134,9 @@
/* cirrus_vga.c */
void pci_cirrus_vga_init(PCIBus *bus, DisplayState *ds, uint8_t *vga_ram_base,
- unsigned long vga_ram_offset, int vga_ram_size);
+ ram_addr_t vga_ram_offset, int vga_ram_size);
void isa_cirrus_vga_init(DisplayState *ds, uint8_t *vga_ram_base,
- unsigned long vga_ram_offset, int vga_ram_size);
+ ram_addr_t vga_ram_offset, int vga_ram_size);
/* ide.c */
void isa_ide_init(int iobase, int iobase2, qemu_irq irq,
Modified: trunk/hw/vga.c
===================================================================
--- trunk/hw/vga.c 2008-11-24 19:29:13 UTC (rev 5789)
+++ trunk/hw/vga.c 2008-11-24 19:33:59 UTC (rev 5790)
@@ -2105,7 +2105,7 @@
}
void vga_common_init(VGAState *s, DisplayState *ds, uint8_t *vga_ram_base,
- unsigned long vga_ram_offset, int vga_ram_size)
+ ram_addr_t vga_ram_offset, int vga_ram_size)
{
int i, j, v, b;
Modified: trunk/hw/vga_int.h
===================================================================
--- trunk/hw/vga_int.h 2008-11-24 19:29:13 UTC (rev 5789)
+++ trunk/hw/vga_int.h 2008-11-24 19:33:59 UTC (rev 5790)
@@ -100,7 +100,7 @@
#define VGA_STATE_COMMON \
uint8_t *vram_ptr; \
- unsigned long vram_offset; \
+ ram_addr_t vram_offset; \
unsigned int vram_size; \
unsigned long bios_offset; \
unsigned int bios_size; \
@@ -186,7 +186,7 @@
}
void vga_common_init(VGAState *s, DisplayState *ds, uint8_t *vga_ram_base,
- unsigned long vga_ram_offset, int vga_ram_size);
+ ram_addr_t vga_ram_offset, int vga_ram_size);
void vga_init(VGAState *s);
uint32_t vga_mem_readb(void *opaque, target_phys_addr_t addr);
void vga_mem_writeb(void *opaque, target_phys_addr_t addr, uint32_t val);
reply other threads:[~2008-11-24 19:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1L4hC4-0000KM-AX@cvs.savannah.gnu.org \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).