From: Blue Swirl <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [5813] Fix command len detection (esp_3_cmdlen.diff)
Date: Sat, 29 Nov 2008 16:51:02 +0000 [thread overview]
Message-ID: <E1L6T26-0000u7-RV@cvs.savannah.gnu.org> (raw)
Revision: 5813
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5813
Author: blueswir1
Date: 2008-11-29 16:51:02 +0000 (Sat, 29 Nov 2008)
Log Message:
-----------
Fix command len detection (esp_3_cmdlen.diff)
When command is not DMA, TCMID and TCLO registers are not filled. Use command buffer len instead
Signed-off-by: Herve Poussineau <hpoussin@reactos.org>
Modified Paths:
--------------
trunk/hw/esp.c
Modified: trunk/hw/esp.c
===================================================================
--- trunk/hw/esp.c 2008-11-29 16:48:29 UTC (rev 5812)
+++ trunk/hw/esp.c 2008-11-29 16:51:02 UTC (rev 5813)
@@ -167,16 +167,16 @@
uint32_t dmalen;
int target;
- dmalen = s->rregs[ESP_TCLO] | (s->rregs[ESP_TCMID] << 8);
target = s->wregs[ESP_WBUSID] & BUSID_DID;
- DPRINTF("get_cmd: len %d target %d\n", dmalen, target);
if (s->dma) {
+ dmalen = s->rregs[ESP_TCLO] | (s->rregs[ESP_TCMID] << 8);
s->dma_memory_read(s->dma_opaque, buf, dmalen);
} else {
+ dmalen = s->ti_size;
+ memcpy(buf, s->ti_buf, dmalen);
buf[0] = 0;
- memcpy(&buf[1], s->ti_buf, dmalen);
- dmalen++;
}
+ DPRINTF("get_cmd: len %d target %d\n", dmalen, target);
s->ti_size = 0;
s->ti_rptr = 0;
reply other threads:[~2008-11-29 16:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1L6T26-0000u7-RV@cvs.savannah.gnu.org \
--to=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).