qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [5856] Exclude unix: from vnc call to unix_listen() (Ryan Harper)
@ 2008-12-02 20:02 Anthony Liguori
  0 siblings, 0 replies; only message in thread
From: Anthony Liguori @ 2008-12-02 20:02 UTC (permalink / raw)
  To: qemu-devel

Revision: 5856
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5856
Author:   aliguori
Date:     2008-12-02 20:02:14 +0000 (Tue, 02 Dec 2008)

Log Message:
-----------
Exclude unix: from vnc call to unix_listen() (Ryan Harper)

When using an existing unix socket like:

 -vnc unix:/tmp/file1Y2nY2

qemu fails to bind a unix socket because the vnc call to unix_listen includes
the unix: prefix and stores that in the unix.sun_path.  The fix is to not pass
in unix: for the filename (same way qemu-char.c does it).

Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Modified Paths:
--------------
    trunk/vnc.c

Modified: trunk/vnc.c
===================================================================
--- trunk/vnc.c	2008-12-02 19:40:26 UTC (rev 5855)
+++ trunk/vnc.c	2008-12-02 20:02:14 UTC (rev 5856)
@@ -2544,7 +2544,7 @@
         dpy = qemu_malloc(256);
         if (strncmp(display, "unix:", 5) == 0) {
             strcpy(dpy, "unix:");
-            vs->lsock = unix_listen(display, dpy+5, 256-5);
+            vs->lsock = unix_listen(display+5, dpy+5, 256-5);
         } else {
             vs->lsock = inet_listen(display, dpy, 256, SOCK_STREAM, 5900);
         }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-12-02 20:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-02 20:02 [Qemu-devel] [5856] Exclude unix: from vnc call to unix_listen() (Ryan Harper) Anthony Liguori

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).