From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L8LFx-0004Jo-1M
	for qemu-devel@nongnu.org; Thu, 04 Dec 2008 15:57:05 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L8LFw-0004II-64
	for qemu-devel@nongnu.org; Thu, 04 Dec 2008 15:57:04 -0500
Received: from [199.232.76.173] (port=52193 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L8LFv-0004IE-Sn
	for qemu-devel@nongnu.org; Thu, 04 Dec 2008 15:57:03 -0500
Received: from savannah.gnu.org ([199.232.41.3]:41542 helo=sv.gnu.org)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <INVALID.NOREPLY@gnu.org>)
	id 1L8LFv-0004RG-J4
	for qemu-devel@nongnu.org; Thu, 04 Dec 2008 15:57:03 -0500
Received: from cvs.savannah.gnu.org ([199.232.41.69])
	by sv.gnu.org with esmtp (Exim 4.63)
	(envelope-from <INVALID.NOREPLY@gnu.org>) id 1L8LFv-0000Qt-2a
	for qemu-devel@nongnu.org; Thu, 04 Dec 2008 20:57:03 +0000
Received: from aurel32 by cvs.savannah.gnu.org with local (Exim 4.63)
	(envelope-from <aurel32@savannah.gnu.org>) id 1L8LFu-0000Qp-Qj
	for qemu-devel@nongnu.org; Thu, 04 Dec 2008 20:57:02 +0000
MIME-Version: 1.0
Errors-To: aurel32
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Aurelien Jarno <aurelien@aurel32.net>
Message-Id: <E1L8LFu-0000Qp-Qj@cvs.savannah.gnu.org>
Date: Thu, 04 Dec 2008 20:57:02 +0000
Subject: [Qemu-devel] [5876] hw/apic.c: use fls() from host-utils
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Revision: 5876
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5876
Author:   aurel32
Date:     2008-12-04 20:57:02 +0000 (Thu, 04 Dec 2008)

Log Message:
-----------
hw/apic.c: use fls() from host-utils

...and fix a bug, the implementation in hw/apic.c was wrong.

Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

Modified Paths:
--------------
    trunk/hw/apic.c

Modified: trunk/hw/apic.c
===================================================================
--- trunk/hw/apic.c	2008-12-04 20:35:16 UTC (rev 5875)
+++ trunk/hw/apic.c	2008-12-04 20:57:02 UTC (rev 5876)
@@ -105,12 +105,6 @@
 static void apic_set_irq(APICState *s, int vector_num, int trigger_mode);
 static void apic_update_irq(APICState *s);
 
-/* Find first bit starting from msb */
-static int fls_bit(uint32_t value)
-{
-    return 31 - clz32(value);
-}
-
 /* Find first bit starting from lsb */
 static int ffs_bit(uint32_t value)
 {
@@ -306,7 +300,7 @@
     int i;
     for(i = 7; i >= 0; i--) {
         if (tab[i] != 0) {
-            return i * 32 + fls_bit(tab[i]);
+            return i * 32 + fls(tab[i]);
         }
     }
     return -1;