From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L9JYc-00028W-SM for qemu-devel@nongnu.org; Sun, 07 Dec 2008 08:20:22 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L9JYc-00028E-En for qemu-devel@nongnu.org; Sun, 07 Dec 2008 08:20:22 -0500 Received: from [199.232.76.173] (port=48759 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L9JYc-00028B-AN for qemu-devel@nongnu.org; Sun, 07 Dec 2008 08:20:22 -0500 Received: from savannah.gnu.org ([199.232.41.3]:39808 helo=sv.gnu.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L9JYc-0006h4-3Y for qemu-devel@nongnu.org; Sun, 07 Dec 2008 08:20:22 -0500 Received: from cvs.savannah.gnu.org ([199.232.41.69]) by sv.gnu.org with esmtp (Exim 4.63) (envelope-from ) id 1L9JYa-0006c1-Dk for qemu-devel@nongnu.org; Sun, 07 Dec 2008 13:20:20 +0000 Received: from balrog by cvs.savannah.gnu.org with local (Exim 4.63) (envelope-from ) id 1L9JYY-0006bs-Tb for qemu-devel@nongnu.org; Sun, 07 Dec 2008 13:20:19 +0000 MIME-Version: 1.0 Errors-To: balrog Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Andrzej Zaborowski Message-Id: Date: Sun, 07 Dec 2008 13:20:18 +0000 Subject: [Qemu-devel] [5907] ARM: cosmetics (Laurent Desnogues). Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Revision: 5907 http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5907 Author: balrog Date: 2008-12-07 13:20:16 +0000 (Sun, 07 Dec 2008) Log Message: ----------- ARM: cosmetics (Laurent Desnogues). - remove macros that are not used - remove disass structure is_mem field which value is never used - correct a typo in a comment. Signed-off-by: Laurent Desnogues Signed-off-by: Andrzej Zaborowski Modified Paths: -------------- trunk/target-arm/translate.c Modified: trunk/target-arm/translate.c =================================================================== --- trunk/target-arm/translate.c 2008-12-07 12:52:07 UTC (rev 5906) +++ trunk/target-arm/translate.c 2008-12-07 13:20:16 UTC (rev 5907) @@ -57,7 +57,6 @@ struct TranslationBlock *tb; int singlestep_enabled; int thumb; - int is_mem; #if !defined(CONFIG_USER_ONLY) int user; #endif @@ -195,7 +194,6 @@ /* Basic operations. */ #define gen_op_movl_T0_T1() tcg_gen_mov_i32(cpu_T[0], cpu_T[1]) -#define gen_op_movl_T1_T0() tcg_gen_mov_i32(cpu_T[1], cpu_T[0]) #define gen_op_movl_T0_im(im) tcg_gen_movi_i32(cpu_T[0], im) #define gen_op_movl_T1_im(im) tcg_gen_movi_i32(cpu_T[1], im) @@ -219,11 +217,8 @@ #define gen_op_logic_T0_cc() gen_logic_CC(cpu_T[0]); #define gen_op_logic_T1_cc() gen_logic_CC(cpu_T[1]); -#define gen_op_shll_T0_im(im) tcg_gen_shli_i32(cpu_T[0], cpu_T[0], im) #define gen_op_shll_T1_im(im) tcg_gen_shli_i32(cpu_T[1], cpu_T[1], im) #define gen_op_shrl_T1_im(im) tcg_gen_shri_i32(cpu_T[1], cpu_T[1], im) -#define gen_op_sarl_T1_im(im) tcg_gen_sari_i32(cpu_T[1], cpu_T[1], im) -#define gen_op_rorl_T1_im(im) tcg_gen_rori_i32(cpu_T[1], cpu_T[1], im) /* Value extensions. */ #define gen_uxtb(var) tcg_gen_ext8u_i32(var, var) @@ -382,7 +377,6 @@ tcg_gen_shri_i64(tmp1, tmp1, 32); tcg_gen_trunc_i64_i32(b, tmp1); } -#define gen_op_imull_T0_T1() gen_imull(cpu_T[0], cpu_T[1]) /* Swap low and high halfwords. */ static void gen_swap_half(TCGv var) @@ -817,17 +811,6 @@ gen_bx(s, tmp); } -#if defined(CONFIG_USER_ONLY) -#define gen_ldst(name, s) gen_op_##name##_raw() -#else -#define gen_ldst(name, s) do { \ - s->is_mem = 1; \ - if (IS_USER(s)) \ - gen_op_##name##_user(); \ - else \ - gen_op_##name##_kernel(); \ - } while (0) -#endif static inline TCGv gen_ld8s(TCGv addr, int index) { TCGv tmp = new_tmp(); @@ -995,15 +978,6 @@ gen_helper_vfp_##name##s(cpu_F0s, cpu_F0s, cpu_F1s, cpu_env); \ } -#define VFP_OP1(name) \ -static inline void gen_vfp_##name(int dp, int arg) \ -{ \ - if (dp) \ - gen_op_vfp_##name##d(arg); \ - else \ - gen_op_vfp_##name##s(arg); \ -} - VFP_OP2(add) VFP_OP2(sub) VFP_OP2(mul) @@ -6649,7 +6623,6 @@ gen_add_data_offset(s, insn, tmp2); if (insn & (1 << 20)) { /* load */ - s->is_mem = 1; if (insn & (1 << 22)) { tmp = gen_ld8u(tmp2, i); } else { @@ -8625,7 +8598,6 @@ dc->thumb = env->thumb; dc->condexec_mask = (env->condexec_bits & 0xf) << 1; dc->condexec_cond = env->condexec_bits >> 4; - dc->is_mem = 0; #if !defined(CONFIG_USER_ONLY) if (IS_M(env)) { dc->user = ((env->v7m.exception == 0) && (env->v7m.control & 1)); @@ -8729,7 +8701,7 @@ gen_set_label(dc->condlabel); dc->condjmp = 0; } - /* Translation stops when a conditional branch is enoutered. + /* Translation stops when a conditional branch is encountered. * Otherwise the subsequent code could get translated several times. * Also stop translation when a page boundary is reached. This * ensures prefetch aborts occur at the right place. */