[Qemu-devel] [5908] Patch holes in ARM translation (Laurent Desnogues).

[Qemu-devel] [5908] Patch holes in ARM translation (Laurent Desnogues).

[Andrzej Zaborowski]

Revision: 5908
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5908
Author:   balrog
Date:     2008-12-07 13:32:09 +0000 (Sun, 07 Dec 2008)

Log Message:
-----------
Patch holes in ARM translation (Laurent Desnogues).

 - gen_set_CF_bit31:  use the right value to set carry flag
 - shifter_out_im:  remove a spurious semi-colon
 - add a break for VSHRN, VRSHRN, VQSHRN, VQRSHRN
   size 2 case
 - sbfx, ubfx are v6t2 instructions

The correct cps user mode behaviour is unclear so it's left out from the
commit until ARM decides it.

Signed-off-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Signed-off-by: Andrzej Zaborowski <andrew.zaborowski@intel.com>

Modified Paths:
--------------
    trunk/target-arm/translate.c

Modified: trunk/target-arm/translate.c
===================================================================
--- trunk/target-arm/translate.c	2008-12-07 13:20:16 UTC (rev 5907)
+++ trunk/target-arm/translate.c	2008-12-07 13:32:09 UTC (rev 5908)
@@ -415,7 +415,7 @@
 {
     TCGv tmp = new_tmp();
     tcg_gen_shri_i32(tmp, var, 31);
-    gen_set_CF(var);
+    gen_set_CF(tmp);
     dead_tmp(tmp);
 }
 
@@ -490,7 +490,7 @@
         tcg_gen_andi_i32(tmp, var, 1);
     } else {
         tcg_gen_shri_i32(tmp, var, shift);
-        if (shift != 31);
+        if (shift != 31)
             tcg_gen_andi_i32(tmp, tmp, 1);
     }
     gen_set_CF(tmp);
@@ -4618,6 +4618,7 @@
                     imm = (uint32_t)shift;
                     tmp2 = tcg_const_i32(imm);
                     TCGV_UNUSED_I64(tmp64);
+                    break;
                 case 3:
                     tmp64 = tcg_const_i64(shift);
                     TCGV_UNUSED(tmp2);
@@ -6583,6 +6584,7 @@
                         break;
                     case 0x12: case 0x16: case 0x1a: case 0x1e: /* sbfx */
                     case 0x32: case 0x36: case 0x3a: case 0x3e: /* ubfx */
+                        ARCH(6T2);
                         tmp = load_reg(s, rm);
                         shift = (insn >> 7) & 0x1f;
                         i = ((insn >> 16) & 0x1f) + 1;

Re: [Qemu-devel] [5908] Patch holes in ARM translation (Laurent Desnogues).

[Laurent Desnogues]

On Sun, Dec 7, 2008 at 2:32 PM, Andrzej Zaborowski <balrogg@gmail.com> wrote:
>
> The correct cps user mode behaviour is unclear so it's left out from the
> commit until ARM decides it.

It should be left as it is now:  CPS is ignored in user mode.

Thanks,

Laurent