From: Blue Swirl <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [5919] Some fixes for TCG debugging
Date: Sun, 07 Dec 2008 17:16:43 +0000 [thread overview]
Message-ID: <E1L9NFL-0002O1-Tw@cvs.savannah.gnu.org> (raw)
Revision: 5919
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5919
Author: blueswir1
Date: 2008-12-07 17:16:42 +0000 (Sun, 07 Dec 2008)
Log Message:
-----------
Some fixes for TCG debugging
This fixes a few things after Paul's improvements for TCG debugging:
- change TCGv_i64 field name to something different from
TCGv_i32
- fix things in tcg that the above change made visible.
Signed-off-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Modified Paths:
--------------
trunk/tcg/tcg-op.h
trunk/tcg/tcg.c
trunk/tcg/tcg.h
Modified: trunk/tcg/tcg-op.h
===================================================================
--- trunk/tcg/tcg-op.h 2008-12-07 16:23:22 UTC (rev 5918)
+++ trunk/tcg/tcg-op.h 2008-12-07 17:16:42 UTC (rev 5919)
@@ -132,7 +132,7 @@
TCGArg offset)
{
*gen_opc_ptr++ = opc;
- *gen_opparam_ptr++ = GET_TCGV_I32(val);
+ *gen_opparam_ptr++ = GET_TCGV_I64(val);
*gen_opparam_ptr++ = GET_TCGV_PTR(base);
*gen_opparam_ptr++ = offset;
}
@@ -166,7 +166,7 @@
}
static inline void tcg_gen_op4_i64(int opc, TCGv_i64 arg1, TCGv_i64 arg2,
- TCGv_i64 arg3, TCGv_i32 arg4)
+ TCGv_i64 arg3, TCGv_i64 arg4)
{
*gen_opc_ptr++ = opc;
*gen_opparam_ptr++ = GET_TCGV_I64(arg1);
Modified: trunk/tcg/tcg.c
===================================================================
--- trunk/tcg/tcg.c 2008-12-07 16:23:22 UTC (rev 5918)
+++ trunk/tcg/tcg.c 2008-12-07 17:16:42 UTC (rev 5919)
@@ -747,7 +747,7 @@
char *tcg_get_arg_str_i64(TCGContext *s, char *buf, int buf_size, TCGv_i64 arg)
{
- return tcg_get_arg_str_idx(s, buf, buf_size, GET_TCGV_I32(arg));
+ return tcg_get_arg_str_idx(s, buf, buf_size, GET_TCGV_I64(arg));
}
static int helper_cmp(const void *p1, const void *p2)
Modified: trunk/tcg/tcg.h
===================================================================
--- trunk/tcg/tcg.h 2008-12-07 16:23:22 UTC (rev 5918)
+++ trunk/tcg/tcg.h 2008-12-07 17:16:42 UTC (rev 5919)
@@ -126,20 +126,20 @@
typedef struct
{
- int n;
+ int i32;
} TCGv_i32;
typedef struct
{
- int n;
+ int i64;
} TCGv_i64;
#define MAKE_TCGV_I32(i) __extension__ \
({ TCGv_i32 make_tcgv_tmp = {i}; make_tcgv_tmp;})
#define MAKE_TCGV_I64(i) __extension__ \
({ TCGv_i64 make_tcgv_tmp = {i}; make_tcgv_tmp;})
-#define GET_TCGV_I32(t) ((t).n)
-#define GET_TCGV_I64(t) ((t).n)
+#define GET_TCGV_I32(t) ((t).i32)
+#define GET_TCGV_I64(t) ((t).i64)
#if TCG_TARGET_REG_BITS == 32
#define TCGV_LOW(t) MAKE_TCGV_I32(GET_TCGV_I64(t))
#define TCGV_HIGH(t) MAKE_TCGV_I32(GET_TCGV_I64(t) + 1)
reply other threads:[~2008-12-07 17:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1L9NFL-0002O1-Tw@cvs.savannah.gnu.org \
--to=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).