* [Qemu-devel] [5928] SH: Don't subtract bases from access addresses in PCIC.
@ 2008-12-07 19:13 Andrzej Zaborowski
0 siblings, 0 replies; only message in thread
From: Andrzej Zaborowski @ 2008-12-07 19:13 UTC (permalink / raw)
To: qemu-devel
Revision: 5928
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5928
Author: balrog
Date: 2008-12-07 19:13:12 +0000 (Sun, 07 Dec 2008)
Log Message:
-----------
SH: Don't subtract bases from access addresses in PCIC.
Modified Paths:
--------------
trunk/hw/sh_pci.c
Modified: trunk/hw/sh_pci.c
===================================================================
--- trunk/hw/sh_pci.c 2008-12-07 19:08:45 UTC (rev 5927)
+++ trunk/hw/sh_pci.c 2008-12-07 19:13:12 UTC (rev 5928)
@@ -40,7 +40,6 @@
static void sh_pci_reg_write (void *p, target_phys_addr_t addr, uint32_t val)
{
SHPCIC *pcic = p;
- addr -= pcic->regbase;
switch(addr) {
case 0 ... 0xfc:
cpu_to_le32w((uint32_t*)(pcic->dev->config + addr), val);
@@ -63,7 +62,6 @@
static uint32_t sh_pci_reg_read (void *p, target_phys_addr_t addr)
{
SHPCIC *pcic = p;
- addr -= pcic->regbase;
switch(addr) {
case 0 ... 0xfc:
return le32_to_cpup((uint32_t*)(pcic->dev->config + addr));
@@ -78,13 +76,13 @@
static void sh_pci_data_write (SHPCIC *pcic, target_phys_addr_t addr,
uint32_t val, int size)
{
- pci_data_write(pcic->bus, addr - pcic->membase + pcic->mbr, val, size);
+ pci_data_write(pcic->bus, addr + pcic->mbr, val, size);
}
static uint32_t sh_pci_mem_read (SHPCIC *pcic, target_phys_addr_t addr,
int size)
{
- return pci_data_read(pcic->bus, addr - pcic->membase + pcic->mbr, size);
+ return pci_data_read(pcic->bus, addr + pcic->mbr, size);
}
static void sh_pci_writeb (void *p, target_phys_addr_t addr, uint32_t val)
@@ -119,7 +117,7 @@
static int sh_pci_addr2port(SHPCIC *pcic, target_phys_addr_t addr)
{
- return addr - pcic->iopbase + pcic->iobr;
+ return addr + pcic->iobr;
}
static void sh_pci_outb (void *p, target_phys_addr_t addr, uint32_t val)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-12-07 19:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-07 19:13 [Qemu-devel] [5928] SH: Don't subtract bases from access addresses in PCIC Andrzej Zaborowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).