From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LAQkF-0003DE-UU
	for qemu-devel@nongnu.org; Wed, 10 Dec 2008 10:13:00 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LAQkF-0003Ce-7s
	for qemu-devel@nongnu.org; Wed, 10 Dec 2008 10:12:59 -0500
Received: from [199.232.76.173] (port=41059 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LAQkF-0003CZ-0q
	for qemu-devel@nongnu.org; Wed, 10 Dec 2008 10:12:59 -0500
Received: from savannah.gnu.org ([199.232.41.3]:52637 helo=sv.gnu.org)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <INVALID.NOREPLY@gnu.org>)
	id 1LAQkE-00005y-QQ
	for qemu-devel@nongnu.org; Wed, 10 Dec 2008 10:12:58 -0500
Received: from cvs.savannah.gnu.org ([199.232.41.69])
	by sv.gnu.org with esmtp (Exim 4.63)
	(envelope-from <INVALID.NOREPLY@gnu.org>) id 1LAQkE-0004Xi-AX
	for qemu-devel@nongnu.org; Wed, 10 Dec 2008 15:12:58 +0000
Received: from aliguori by cvs.savannah.gnu.org with local (Exim 4.63)
	(envelope-from <aliguori@savannah.gnu.org>) id 1LAQkE-0004Xe-4J
	for qemu-devel@nongnu.org; Wed, 10 Dec 2008 15:12:58 +0000
MIME-Version: 1.0
Errors-To: aliguori
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Anthony Liguori <anthony@codemonkey.ws>
Message-Id: <E1LAQkE-0004Xe-4J@cvs.savannah.gnu.org>
Date: Wed, 10 Dec 2008 15:12:58 +0000
Subject: [Qemu-devel] [5966] Fix off-by-one bug limiting VNC passwords to 7
	chars (Chris Webb)
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Revision: 5966
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5966
Author:   aliguori
Date:     2008-12-10 15:12:57 +0000 (Wed, 10 Dec 2008)

Log Message:
-----------
Fix off-by-one bug limiting VNC passwords to 7 chars (Chris Webb)

monitor_readline expects buf_size to include the terminating \0, but
do_change_vnc in monitor.c calls it as though it doesn't. The other site
where monitor_readline reads a password (in vl.c) passes the buffer 
length
correctly.

Signed-off-by: Chris Webb <chris@arachsys.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Modified Paths:
--------------
    trunk/monitor.c

Modified: trunk/monitor.c
===================================================================
--- trunk/monitor.c	2008-12-10 15:02:33 UTC (rev 5965)
+++ trunk/monitor.c	2008-12-10 15:12:57 UTC (rev 5966)
@@ -434,8 +434,7 @@
     if (strcmp(target, "passwd") == 0 ||
 	strcmp(target, "password") == 0) {
 	char password[9];
-	monitor_readline("Password: ", 1, password, sizeof(password)-1);
-	password[sizeof(password)-1] = '\0';
+	monitor_readline("Password: ", 1, password, sizeof(password));
 	if (vnc_display_password(NULL, password) < 0)
 	    term_printf("could not set VNC server password\n");
     } else {