From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LBbJI-0003By-FE
	for qemu-devel@nongnu.org; Sat, 13 Dec 2008 15:42:00 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LBbJH-0003BS-Ph
	for qemu-devel@nongnu.org; Sat, 13 Dec 2008 15:42:00 -0500
Received: from [199.232.76.173] (port=56579 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LBbJH-0003BF-JQ
	for qemu-devel@nongnu.org; Sat, 13 Dec 2008 15:41:59 -0500
Received: from savannah.gnu.org ([199.232.41.3]:40838 helo=sv.gnu.org)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <INVALID.NOREPLY@gnu.org>)
	id 1LBbJH-0005cW-AJ
	for qemu-devel@nongnu.org; Sat, 13 Dec 2008 15:41:59 -0500
Received: from cvs.savannah.gnu.org ([199.232.41.69])
	by sv.gnu.org with esmtp (Exim 4.63)
	(envelope-from <INVALID.NOREPLY@gnu.org>) id 1LBbJG-00067j-S7
	for qemu-devel@nongnu.org; Sat, 13 Dec 2008 20:41:58 +0000
Received: from aliguori by cvs.savannah.gnu.org with local (Exim 4.63)
	(envelope-from <aliguori@savannah.gnu.org>) id 1LBbJG-00067f-Km
	for qemu-devel@nongnu.org; Sat, 13 Dec 2008 20:41:58 +0000
MIME-Version: 1.0
Errors-To: aliguori
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Anthony Liguori <anthony@codemonkey.ws>
Message-Id: <E1LBbJG-00067f-Km@cvs.savannah.gnu.org>
Date: Sat, 13 Dec 2008 20:41:58 +0000
Subject: [Qemu-devel] [6017] Correctly initialize msr list in KVM
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Revision: 6017
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6017
Author:   aliguori
Date:     2008-12-13 20:41:58 +0000 (Sat, 13 Dec 2008)

Log Message:
-----------
Correctly initialize msr list in KVM

I believe this was spotted by Gerd Hoffman but I can't find his patch 
now.  This will cause very subtle corruption on the heap because we 
don't allocate the appropriately sized buffer.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Modified Paths:
--------------
    trunk/target-i386/kvm.c

Modified: trunk/target-i386/kvm.c
===================================================================
--- trunk/target-i386/kvm.c	2008-12-13 19:27:22 UTC (rev 6016)
+++ trunk/target-i386/kvm.c	2008-12-13 20:41:58 UTC (rev 6017)
@@ -90,11 +90,11 @@
 
         /* Obtain MSR list from KVM.  These are the MSRs that we must
          * save/restore */
+        msr_list.nmsrs = 0;
         ret = kvm_ioctl(env->kvm_state, KVM_GET_MSR_INDEX_LIST, &msr_list);
         if (ret < 0)
             return 0;
 
-        msr_list.nmsrs = 0;
         kvm_msr_list = qemu_mallocz(sizeof(msr_list) +
                                     msr_list.nmsrs * sizeof(msr_list.indices[0]));
         if (kvm_msr_list == NULL)