From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LBwBL-0001p4-ML for qemu-devel@nongnu.org; Sun, 14 Dec 2008 13:59:11 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LBwBK-0001of-Si for qemu-devel@nongnu.org; Sun, 14 Dec 2008 13:59:11 -0500 Received: from [199.232.76.173] (port=41485 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LBwBK-0001oR-LW for qemu-devel@nongnu.org; Sun, 14 Dec 2008 13:59:10 -0500 Received: from savannah.gnu.org ([199.232.41.3]:55231 helo=sv.gnu.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LBwBK-0004wY-5V for qemu-devel@nongnu.org; Sun, 14 Dec 2008 13:59:10 -0500 Received: from cvs.savannah.gnu.org ([199.232.41.69]) by sv.gnu.org with esmtp (Exim 4.63) (envelope-from ) id 1LBwBJ-0000eP-Ix for qemu-devel@nongnu.org; Sun, 14 Dec 2008 18:59:09 +0000 Received: from aurel32 by cvs.savannah.gnu.org with local (Exim 4.63) (envelope-from ) id 1LBwBJ-0000eK-8I for qemu-devel@nongnu.org; Sun, 14 Dec 2008 18:59:09 +0000 MIME-Version: 1.0 Errors-To: aurel32 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Aurelien Jarno Message-Id: Date: Sun, 14 Dec 2008 18:59:09 +0000 Subject: [Qemu-devel] [6033] target-ppc: remove FPRF optimization Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Revision: 6033 http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6033 Author: aurel32 Date: 2008-12-14 18:59:08 +0000 (Sun, 14 Dec 2008) Log Message: ----------- target-ppc: remove FPRF optimization FPRF optimization is totally broken, remove it. Signed-off-by: Aurelien Jarno Modified Paths: -------------- trunk/target-ppc/translate.c Modified: trunk/target-ppc/translate.c =================================================================== --- trunk/target-ppc/translate.c 2008-12-14 18:40:58 UTC (rev 6032) +++ trunk/target-ppc/translate.c 2008-12-14 18:59:08 UTC (rev 6033) @@ -41,7 +41,6 @@ //#define DO_SINGLE_STEP //#define PPC_DEBUG_DISAS //#define DO_PPC_STATISTICS -//#define OPTIMIZE_FPRF_UPDATE /*****************************************************************************/ /* Code translation helpers */ @@ -162,11 +161,6 @@ done_init = 1; } -#if defined(OPTIMIZE_FPRF_UPDATE) -static uint16_t *gen_fprf_buf[OPC_BUF_SIZE]; -static uint16_t **gen_fprf_ptr; -#endif - /* internal defines */ typedef struct DisasContext { struct TranslationBlock *tb; @@ -216,9 +210,6 @@ if (set_fprf != 0) { /* This case might be optimized later */ -#if defined(OPTIMIZE_FPRF_UPDATE) - *gen_fprf_ptr++ = gen_opc_ptr; -#endif tcg_gen_movi_i32(t0, 1); gen_helper_compute_fprf(t0, arg, t0); if (unlikely(set_rc)) { @@ -235,17 +226,6 @@ tcg_temp_free_i32(t0); } -static always_inline void gen_optimize_fprf (void) -{ -#if defined(OPTIMIZE_FPRF_UPDATE) - uint16_t **ptr; - - for (ptr = gen_fprf_buf; ptr != (gen_fprf_ptr - 1); ptr++) - *ptr = INDEX_op_nop1; - gen_fprf_ptr = gen_fprf_buf; -#endif -} - static always_inline void gen_set_access_type (DisasContext *ctx, int access_type) { if (ctx->access_type != access_type) { @@ -2326,7 +2306,6 @@ gen_exception(ctx, POWERPC_EXCP_FPU); return; } - gen_optimize_fprf(); bfa = 4 * (7 - crfS(ctx->opcode)); tcg_gen_shri_i32(cpu_crf[crfD(ctx->opcode)], cpu_fpscr, bfa); tcg_gen_andi_i32(cpu_crf[crfD(ctx->opcode)], cpu_crf[crfD(ctx->opcode)], 0xf); @@ -2340,7 +2319,6 @@ gen_exception(ctx, POWERPC_EXCP_FPU); return; } - gen_optimize_fprf(); gen_reset_fpstatus(); tcg_gen_extu_i32_i64(cpu_fpr[rD(ctx->opcode)], cpu_fpscr); gen_compute_fprf(cpu_fpr[rD(ctx->opcode)], 0, Rc(ctx->opcode) != 0); @@ -2356,7 +2334,6 @@ return; } crb = 31 - crbD(ctx->opcode); - gen_optimize_fprf(); gen_reset_fpstatus(); if (likely(crb != FPSCR_FEX && crb != FPSCR_VX)) { TCGv_i32 t0 = tcg_const_i32(crb); @@ -2378,7 +2355,6 @@ return; } crb = 31 - crbD(ctx->opcode); - gen_optimize_fprf(); gen_reset_fpstatus(); /* XXX: we pretend we can only do IEEE floating-point computations */ if (likely(crb != FPSCR_FEX && crb != FPSCR_VX && crb != FPSCR_NI)) { @@ -2402,7 +2378,6 @@ gen_exception(ctx, POWERPC_EXCP_FPU); return; } - gen_optimize_fprf(); gen_reset_fpstatus(); t0 = tcg_const_i32(FM(ctx->opcode)); gen_helper_store_fpscr(cpu_fpr[rB(ctx->opcode)], t0); @@ -2427,7 +2402,6 @@ } bf = crbD(ctx->opcode) >> 2; sh = 7 - bf; - gen_optimize_fprf(); gen_reset_fpstatus(); t0 = tcg_const_i64(FPIMM(ctx->opcode) << (4 * sh)); t1 = tcg_const_i32(1 << sh); @@ -7727,9 +7701,6 @@ pc_start = tb->pc; gen_opc_end = gen_opc_buf + OPC_MAX_SIZE; -#if defined(OPTIMIZE_FPRF_UPDATE) - gen_fprf_ptr = gen_fprf_buf; -#endif ctx.nip = pc_start; ctx.tb = tb; ctx.exception = POWERPC_EXCP_NONE;