* [Qemu-devel] [6054] target-ppc: enable PRECISE_EMULATION by default
@ 2008-12-15 17:14 Aurelien Jarno
2008-12-15 17:57 ` Laurent Desnogues
0 siblings, 1 reply; 3+ messages in thread
From: Aurelien Jarno @ 2008-12-15 17:14 UTC (permalink / raw)
To: qemu-devel
Revision: 6054
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6054
Author: aurel32
Date: 2008-12-15 17:14:50 +0000 (Mon, 15 Dec 2008)
Log Message:
-----------
target-ppc: enable PRECISE_EMULATION by default
With this option enabled, all glibc math tests pass.
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Modified Paths:
--------------
trunk/target-ppc/exec.h
Modified: trunk/target-ppc/exec.h
===================================================================
--- trunk/target-ppc/exec.h 2008-12-15 17:14:43 UTC (rev 6053)
+++ trunk/target-ppc/exec.h 2008-12-15 17:14:50 UTC (rev 6054)
@@ -29,7 +29,7 @@
/* For normal operations, precise emulation should not be needed */
//#define USE_PRECISE_EMULATION 1
-#define USE_PRECISE_EMULATION 0
+#define USE_PRECISE_EMULATION 1
register struct CPUPPCState *env asm(AREG0);
#define TDX "%016" PRIx64
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [6054] target-ppc: enable PRECISE_EMULATION by default
2008-12-15 17:14 [Qemu-devel] [6054] target-ppc: enable PRECISE_EMULATION by default Aurelien Jarno
@ 2008-12-15 17:57 ` Laurent Desnogues
2008-12-15 21:50 ` Aurelien Jarno
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Desnogues @ 2008-12-15 17:57 UTC (permalink / raw)
To: qemu-devel
On Mon, Dec 15, 2008 at 6:14 PM, Aurelien Jarno <aurelien@aurel32.net> wrote:
> Revision: 6054
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6054
> Author: aurel32
> Date: 2008-12-15 17:14:50 +0000 (Mon, 15 Dec 2008)
>
> Log Message:
> -----------
> target-ppc: enable PRECISE_EMULATION by default
>
> With this option enabled, all glibc math tests pass.
[...]
> /* For normal operations, precise emulation should not be needed */
> //#define USE_PRECISE_EMULATION 1
> -#define USE_PRECISE_EMULATION 0
> +#define USE_PRECISE_EMULATION 1
Shouldn't you change the comment too so that one can track
why USE_PRECISE_EMULATION is needed?
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [6054] target-ppc: enable PRECISE_EMULATION by default
2008-12-15 17:57 ` Laurent Desnogues
@ 2008-12-15 21:50 ` Aurelien Jarno
0 siblings, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2008-12-15 21:50 UTC (permalink / raw)
To: qemu-devel
On Mon, Dec 15, 2008 at 06:57:39PM +0100, Laurent Desnogues wrote:
> On Mon, Dec 15, 2008 at 6:14 PM, Aurelien Jarno <aurelien@aurel32.net> wrote:
> > Revision: 6054
> > http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6054
> > Author: aurel32
> > Date: 2008-12-15 17:14:50 +0000 (Mon, 15 Dec 2008)
> >
> > Log Message:
> > -----------
> > target-ppc: enable PRECISE_EMULATION by default
> >
> > With this option enabled, all glibc math tests pass.
> [...]
> > /* For normal operations, precise emulation should not be needed */
> > //#define USE_PRECISE_EMULATION 1
> > -#define USE_PRECISE_EMULATION 0
> > +#define USE_PRECISE_EMULATION 1
>
> Shouldn't you change the comment too so that one can track
> why USE_PRECISE_EMULATION is needed?
That is fixed in revision 6058. BTW I wonder if we should really
maintain two versions of the code that in most case only differs
by a few checks on the operand. Those checks are a and operation
followed by a comparison, so they probably take very few time compared
to the actual computation.
Any opinion?
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-12-15 21:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-15 17:14 [Qemu-devel] [6054] target-ppc: enable PRECISE_EMULATION by default Aurelien Jarno
2008-12-15 17:57 ` Laurent Desnogues
2008-12-15 21:50 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).