From: Paul Brook <paul@nowt.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [6100] When -icount is used and a TB is recompiled due to an IO access
Date: Fri, 19 Dec 2008 12:49:13 +0000 [thread overview]
Message-ID: <E1LDen3-0000aL-Hf@cvs.savannah.gnu.org> (raw)
Revision: 6100
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6100
Author: pbrook
Date: 2008-12-19 12:49:13 +0000 (Fri, 19 Dec 2008)
Log Message:
-----------
When -icount is used and a TB is recompiled due to an IO access
shortly after an IRQ has been raised, env->exception_index will still be set
to EXCP_IRQ when cpu_io_recompile calls cpu_resume_from_signal.
This causes qemu to repeat the IRQ trap, with disasterous consequences.
I suspect this "works" most of the time because linux tends to drop back to
svc mode before doing actual IRQ processing, and be fairly
tolerant of spurious IRQ traps.
Signed-off-by: Paul Brook <paul@codesourcery.com>
Modified Paths:
--------------
trunk/cpu-exec.c
Modified: trunk/cpu-exec.c
===================================================================
--- trunk/cpu-exec.c 2008-12-19 12:39:00 UTC (rev 6099)
+++ trunk/cpu-exec.c 2008-12-19 12:49:13 UTC (rev 6100)
@@ -86,6 +86,7 @@
#endif
}
#endif
+ env->exception_index = -1;
longjmp(env->jmp_env, 1);
}
reply other threads:[~2008-12-19 12:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1LDen3-0000aL-Hf@cvs.savannah.gnu.org \
--to=paul@nowt.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).