qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [6110] Add patch to allow Bochs patch queue to be built from another directory.
Date: Fri, 19 Dec 2008 18:59:11 +0000	[thread overview]
Message-ID: <E1LDkZ5-0003pc-4I@cvs.savannah.gnu.org> (raw)

Revision: 6110
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6110
Author:   aliguori
Date:     2008-12-19 18:59:10 +0000 (Fri, 19 Dec 2008)

Log Message:
-----------
Add patch to allow Bochs patch queue to be built from another directory.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Modified Paths:
--------------
    trunk/pc-bios/bios-pq/series

Added Paths:
-----------
    trunk/pc-bios/bios-pq/0007_separate-build-dir.patch

Added: trunk/pc-bios/bios-pq/0007_separate-build-dir.patch
===================================================================
--- trunk/pc-bios/bios-pq/0007_separate-build-dir.patch	                        (rev 0)
+++ trunk/pc-bios/bios-pq/0007_separate-build-dir.patch	2008-12-19 18:59:10 UTC (rev 6110)
@@ -0,0 +1,33 @@
+Fix bochs bios build from a separate directory
+
+Bochs keeps the BIOS-bochs-latest and BIOS-bochs-legacy binaries under revision
+control.  Since the build changes these binaries, and guilt cannot handle
+changed binaries, it makes it very difficult to work with a patch queue if
+you're building from the same tree as the source is located.
+
+Bochs has some support for building from a separate directory but it's currently
+broken.  This patch fixes that and allows for a sane work flow when developing
+BIOS changes for QEMU.
+
+Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
+
+diff --git a/bios/Makefile.in b/bios/Makefile.in
+index 5c7bd4f..3d3d195 100644
+--- a/bios/Makefile.in
++++ b/bios/Makefile.in
+@@ -98,7 +98,7 @@ rombios32.bin: rombios32.out rombios.h
+ 	./biossums -pad $@
+ 
+ rombios32.out: rombios32start.o rombios32.o rombios32.ld
+-	ld -o $@ -T rombios32.ld rombios32start.o rombios32.o
++	ld -o $@ -T $(srcdir)/rombios32.ld rombios32start.o rombios32.o
+ 
+ rombios32.o: rombios32.c acpi-dsdt.hex
+ 	$(GCC32) -O2 -Wall -c -o $@ $<
+@@ -115,5 +115,4 @@ rombios32start.o: rombios32start.S
+ BIOS-bochs-latest: rombios16.bin rombios32.bin
+ 	cat rombios32.bin rombios16.bin > $@
+ 
+-biossums: biossums.c
+-	$(GCC) -o biossums biossums.c
++biossums: biossums.o

Modified: trunk/pc-bios/bios-pq/series
===================================================================
--- trunk/pc-bios/bios-pq/series	2008-12-19 16:22:03 UTC (rev 6109)
+++ trunk/pc-bios/bios-pq/series	2008-12-19 18:59:10 UTC (rev 6110)
@@ -4,3 +4,4 @@
 0004_no-stack-protector.patch
 0005_hpet.patch
 0006_acpi-packing.patch
+0007_separate-build-dir.patch

             reply	other threads:[~2008-12-19 18:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-19 18:59 Anthony Liguori [this message]
2008-12-20 14:38 ` [Qemu-devel] [6110] Add patch to allow Bochs patch queue to be built from another directory Volker Ruppert
2008-12-21  1:26   ` Anthony Liguori
2008-12-25 17:17     ` Volker Ruppert
2008-12-21 16:24   ` [Qemu-devel] Re: [6110] Add patch to allow Bochs patch queue to bebuilt " Sebastian Herbszt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1LDkZ5-0003pc-4I@cvs.savannah.gnu.org \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).