From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [6245] qcow2: free old snapshots array upon creation of a new one ( Uri Lublin)
Date: Thu, 08 Jan 2009 19:32:20 +0000 [thread overview]
Message-ID: <E1LL0c8-0006gy-Hn@cvs.savannah.gnu.org> (raw)
Revision: 6245
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6245
Author: aliguori
Date: 2009-01-08 19:32:20 +0000 (Thu, 08 Jan 2009)
Log Message:
-----------
qcow2: free old snapshots array upon creation of a new one (Uri Lublin)
Don't leak memory
Rebased for qemu tree.
Signed-off-by: Uri Lublin <uril@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Modified Paths:
--------------
trunk/block-qcow2.c
Modified: trunk/block-qcow2.c
===================================================================
--- trunk/block-qcow2.c 2009-01-08 19:29:03 UTC (rev 6244)
+++ trunk/block-qcow2.c 2009-01-08 19:32:20 UTC (rev 6245)
@@ -2024,6 +2024,7 @@
if (!snapshots1)
goto fail;
memcpy(snapshots1, s->snapshots, s->nb_snapshots * sizeof(QCowSnapshot));
+ qemu_free(s->snapshots);
s->snapshots = snapshots1;
s->snapshots[s->nb_snapshots++] = *sn;
reply other threads:[~2009-01-08 19:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1LL0c8-0006gy-Hn@cvs.savannah.gnu.org \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).