From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LL0cA-0000Bt-QZ
	for qemu-devel@nongnu.org; Thu, 08 Jan 2009 14:32:22 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LL0cA-0000B0-1D
	for qemu-devel@nongnu.org; Thu, 08 Jan 2009 14:32:22 -0500
Received: from [199.232.76.173] (port=39906 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LL0c9-0000Ae-QS
	for qemu-devel@nongnu.org; Thu, 08 Jan 2009 14:32:21 -0500
Received: from savannah.gnu.org ([199.232.41.3]:50290 helo=sv.gnu.org)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <INVALID.NOREPLY@gnu.org>)
	id 1LL0c9-0005ZV-Ge
	for qemu-devel@nongnu.org; Thu, 08 Jan 2009 14:32:21 -0500
Received: from cvs.savannah.gnu.org ([199.232.41.69])
	by sv.gnu.org with esmtp (Exim 4.63)
	(envelope-from <INVALID.NOREPLY@gnu.org>) id 1LL0c8-0006h2-S5
	for qemu-devel@nongnu.org; Thu, 08 Jan 2009 19:32:20 +0000
Received: from aliguori by cvs.savannah.gnu.org with local (Exim 4.63)
	(envelope-from <aliguori@savannah.gnu.org>) id 1LL0c8-0006gy-Hn
	for qemu-devel@nongnu.org; Thu, 08 Jan 2009 19:32:20 +0000
MIME-Version: 1.0
Errors-To: aliguori
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Anthony Liguori <anthony@codemonkey.ws>
Message-Id: <E1LL0c8-0006gy-Hn@cvs.savannah.gnu.org>
Date: Thu, 08 Jan 2009 19:32:20 +0000
Subject: [Qemu-devel] [6245] qcow2: free old snapshots array upon creation
 of a new one ( Uri Lublin)
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Revision: 6245
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6245
Author:   aliguori
Date:     2009-01-08 19:32:20 +0000 (Thu, 08 Jan 2009)

Log Message:
-----------
qcow2: free old snapshots array upon creation of a new one (Uri Lublin)

Don't leak memory

Rebased for qemu tree.

Signed-off-by: Uri Lublin <uril@redhat.com> 
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Modified Paths:
--------------
    trunk/block-qcow2.c

Modified: trunk/block-qcow2.c
===================================================================
--- trunk/block-qcow2.c	2009-01-08 19:29:03 UTC (rev 6244)
+++ trunk/block-qcow2.c	2009-01-08 19:32:20 UTC (rev 6245)
@@ -2024,6 +2024,7 @@
     if (!snapshots1)
         goto fail;
     memcpy(snapshots1, s->snapshots, s->nb_snapshots * sizeof(QCowSnapshot));
+    qemu_free(s->snapshots);
     s->snapshots = snapshots1;
     s->snapshots[s->nb_snapshots++] = *sn;