From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [6291] Make virtio_net_init() return void (Mark McLoughlin)
Date: Tue, 13 Jan 2009 21:09:18 +0000 [thread overview]
Message-ID: <E1LMqVi-0000w1-LF@cvs.savannah.gnu.org> (raw)
Revision: 6291
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6291
Author: aliguori
Date: 2009-01-13 21:09:18 +0000 (Tue, 13 Jan 2009)
Log Message:
-----------
Make virtio_net_init() return void (Mark McLoughlin)
All PCI NIC init functions return void and nothing uses the
return value from virtio_net_init().
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Modified Paths:
--------------
trunk/hw/virtio-net.c
trunk/hw/virtio-net.h
Modified: trunk/hw/virtio-net.c
===================================================================
--- trunk/hw/virtio-net.c 2009-01-13 20:08:43 UTC (rev 6290)
+++ trunk/hw/virtio-net.c 2009-01-13 21:09:18 UTC (rev 6291)
@@ -315,7 +315,7 @@
return 0;
}
-PCIDevice *virtio_net_init(PCIBus *bus, NICInfo *nd, int devfn)
+void virtio_net_init(PCIBus *bus, NICInfo *nd, int devfn)
{
VirtIONet *n;
static int virtio_net_id;
@@ -326,7 +326,7 @@
sizeof(struct virtio_net_config),
sizeof(VirtIONet));
if (!n)
- return NULL;
+ return;
n->vdev.get_config = virtio_net_update_config;
n->vdev.get_features = virtio_net_get_features;
@@ -347,6 +347,4 @@
register_savevm("virtio-net", virtio_net_id++, 2,
virtio_net_save, virtio_net_load, n);
-
- return (PCIDevice *)n;
}
Modified: trunk/hw/virtio-net.h
===================================================================
--- trunk/hw/virtio-net.h 2009-01-13 20:08:43 UTC (rev 6290)
+++ trunk/hw/virtio-net.h 2009-01-13 21:09:18 UTC (rev 6291)
@@ -80,6 +80,6 @@
uint16_t num_buffers; /* Number of merged rx buffers */
};
-PCIDevice *virtio_net_init(PCIBus *bus, NICInfo *nd, int devfn);
+void virtio_net_init(PCIBus *bus, NICInfo *nd, int devfn);
#endif
reply other threads:[~2009-01-13 21:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1LMqVi-0000w1-LF@cvs.savannah.gnu.org \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).